Skip to content

Update Combo and Simple Combo Keyboard Navigation & Add Escape Key behavior #16246

Merged
rkaraivanov merged 10 commits intomasterfrom
mkirkova/combo-navigation-16223
Feb 2, 2026
Merged

Update Combo and Simple Combo Keyboard Navigation & Add Escape Key behavior #16246
rkaraivanov merged 10 commits intomasterfrom
mkirkova/combo-navigation-16223

Conversation

@MonikaKirkova
Copy link
Copy Markdown
Contributor

Closes #16223

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MonikaKirkova MonikaKirkova added the ❌ status: awaiting-test PRs awaiting manual verification label Sep 25, 2025
@Lipata Lipata requested a review from Copilot October 24, 2025 11:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates keyboard navigation for Combo and Simple Combo components by adding Escape key behavior and improving Tab key handling. When the dropdown is collapsed, pressing Escape now clears the selection. When the dropdown is open, pressing Escape closes it. Tab key behavior is refined to properly close the dropdown and move focus to the next element.

Key changes:

  • Added Escape key handler to clear selection when combo is collapsed and close dropdown when open
  • Modified Tab key handling to prevent default behavior only for navigation keys (excluding Tab)
  • Removed keyboard event handlers from clear and toggle buttons, simplifying the interaction model

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
simple-combo.component.ts Added Escape key handler and consolidated clear button logic
simple-combo.component.spec.ts Added tests for Escape key behavior and updated Tab key test
simple-combo.component.html Removed keyboard handlers and tabindex from clear/toggle buttons
combo.component.ts Added Escape key handler and consolidated clear button logic
combo.component.spec.ts Added tests for Escape and Tab key behaviors
combo.component.html Removed keyboard handlers and tabindex from clear/toggle buttons
combo.common.ts Enhanced close handler to detect Tab key and refocus input
combo-dropdown.component.ts Separated Tab and Escape key handling in action handler
drop-down-navigation.directive.ts Updated to allow Tab key default behavior
query-builder-functions.spec.ts Updated test expectations after toggle button removal from tab order
CHANGELOG.md Documented new keyboard navigation features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Lipata
Lipata previously approved these changes Oct 27, 2025
@Lipata Lipata requested a review from rkaraivanov October 27, 2025 10:42
@rkaraivanov rkaraivanov requested a review from Copilot February 2, 2026 10:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 2, 2026
@rkaraivanov rkaraivanov merged commit c3cb139 into master Feb 2, 2026
6 checks passed
@rkaraivanov rkaraivanov deleted the mkirkova/combo-navigation-16223 branch February 2, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refine Combo Component Keyboard Navigation & Escape Key Behavior

5 participants