fix(igxGrid): Fix offset when using virtual scrollbar with ratio.#16346
Merged
fix(igxGrid): Fix offset when using virtual scrollbar with ratio.#16346
Conversation
MayaKirova
added
❌ status: awaiting-test
Member
|
#16408 Is still reproducible on my end here |
added 2 commits
November 3, 2025 11:11
Contributor
Author
Should be fixed now. |
added 5 commits
November 3, 2025 13:54
mddragnev
previously approved these changes
Nov 26, 2025
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
bot
added
the
status: inactive
dkamburov
added
version: 21.2.x
and removed
version: 20.2.x
status: inactive
IMinchev64
added
💥 status: in-test
Contributor
|
Can you please resolve conflicts and create a PR for 21.1.x as well? |
IMinchev64
added
✅ status: verified
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses grid cell-merging layout issues when using very large virtual scroll sizes that exceed browser limits, causing the virtual scrollbar to operate with a ratio and requiring offset calculations to use the virtual scroll position.
Changes:
- Adjusts virtualization logic to account for
_virtRatiowhen clamping/setting scrollbar positions and when calculating view offsets. - Updates merged-cell “top retained row” offset calculations to use the virtual scroll position instead of the real scrollbar position.
- Adds/uses an
indexfield on merge-result records to avoid repeated lookups and to help identify merge roots.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid.pipes.ts | Switches unmerge-active logic to use merge-result index instead of indexOf. |
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Uses virtual scroll position for merged-row offset; refactors merged data-in-view tracking. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts | Fixes ratio-based scroll position handling; adjusts scroll offset updates; exposes virtual scroll position. |
| projects/igniteui-angular/core/src/data-operations/merge-strategy.ts | Adds an index field to default merge result records. |
projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts
Show resolved
Hide resolved
projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts
Show resolved
Hide resolved
dkamburov
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16292
Closes #16408
In case scrollbar size exceeds max browser allowed and uses ratio to calc. positions, adjust offset of merged cells accordingly.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)