fix(grid): address null TypeError on focusing a grid with no data and column headers - master#16520
Merged
kacheshmarova merged 4 commits intomasterfrom Nov 26, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a null TypeError that occurs when focusing a grid with no data and column headers. The issue arises when grid.navigation.activeNode is null, causing attempts to access its row property to fail.
Key Changes:
- Added optional chaining (
?.) to safely accessactiveNode.rowin two header components - Added a test case to verify the fix prevents the TypeError
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
grid-header-row.component.ts |
Added optional chaining to prevent null reference error when accessing activeNode.row in isLeafHeaderAriaHidden getter |
grid-header-group.component.ts |
Added optional chaining to prevent null reference error when accessing activeNode.row in ariaHidden getter |
column-group.spec.ts |
Added test case to verify no errors are thrown when focusing a grid with no active node (contains a critical bug in the test implementation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kacheshmarova
approved these changes
Nov 26, 2025
IvanKitanov17
added
💥 status: in-test
kacheshmarova
deleted the
bpachilova/ariaHidden-header-groups-fix-16517
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16517
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)