fix(grid-pinning): remove hide call in scrollToRow - 20.1.x#16780
Merged
fix(grid-pinning): remove hide call in scrollToRow - 20.1.x#16780
Conversation
IMinchev64
added
❌ status: awaiting-test
IMinchev64
changed the title
Member
|
Please cherry-pick your latest commit from master |
mddragnev
previously approved these changes
Mar 9, 2026
MarielaTihova
added
✅ status: verified
Contributor
|
@IMinchev64 seems to fail for that branch |
mddragnev
previously approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue where the Action Strip closes when invoking the “jump to row” (scroll) action while working with pinned rows, by preventing the strip from being hidden in that scenario.
Changes:
- Updates grid vertical scroll handling to keep the Action Strip visible when its context is a connected pinned row (base mode).
- Adjusts pinning “scrollToRow” action to not hide the Action Strip in base mode (still hides in menu mode).
- Extends Action Strip token surface to expose
menuItems, and adds a regression test for base-modescrollToRow.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/src/lib/grids/grid-base.directive.ts | Keeps Action Strip visible during vertical scroll when it’s attached to a pinned, connected row (and not in menu mode). |
| projects/igniteui-angular/src/lib/action-strip/token.ts | Adds menuItems to the injected Action Strip token to support the new scroll logic. |
| projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.ts | Prevents hiding the strip after scrollToRow in base mode; keeps current behavior for menu mode. |
| projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts | Adds a regression test ensuring base-mode scrollToRow doesn’t immediately hide the strip. |
…UI/igniteui-angular into iminchev/fix-16943-20.1.x
mddragnev
requested changes
Apr 6, 2026
…gxGridPinningActionsComponent Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/3f2bf1d7-9d01-4f34-8ab7-adda6e7d4d39 Co-authored-by: dkamburov <1182001+dkamburov@users.noreply.github.com>
dkamburov
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16493
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)