Skip to content

feat(grid-cell): enhance keyboard activation handling and notify grid changes - 20.1.x#16928

Merged
dkamburov merged 5 commits into20.1.xfrom
iminchev/elements-cell-activation-20.1.x
Apr 9, 2026
Merged

feat(grid-cell): enhance keyboard activation handling and notify grid changes - 20.1.x#16928
dkamburov merged 5 commits into20.1.xfrom
iminchev/elements-cell-activation-20.1.x

Conversation

@IMinchev64
Copy link
Copy Markdown
Contributor

@IMinchev64 IMinchev64 commented Feb 18, 2026

Closes #16494

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 91.695% (+0.001%) from 91.694%
when pulling b7bef6f on iminchev/elements-cell-activation-20.1.x
into 93d144f on 20.1.x.

@tishko0 tishko0 self-requested a review February 26, 2026 09:39
tishko0
tishko0 previously approved these changes Feb 26, 2026
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 26, 2026
@dkamburov dkamburov requested a review from MayaKirova March 17, 2026 08:47
MayaKirova
MayaKirova previously approved these changes Mar 17, 2026
Copilot AI review requested due to automatic review settings March 27, 2026 10:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a keyboard navigation focus/activation refresh issue in the grid cell activation flow by explicitly triggering grid change notification when activation originates from a keyboard event (keydown), aligning with the reported Ctrl+Arrow Up/Down focus desync in #16494.

Changes:

  • Detect keyboard-driven cell activation (event.type === 'keydown') in IgxGridCellComponent.activate.
  • Call grid.notifyChanges() on keyboard activation to force a grid refresh/update cycle.

@dkamburov
Copy link
Copy Markdown
Contributor

@IMinchev64 please see the latest comments

@IMinchev64 IMinchev64 dismissed stale reviews from MayaKirova and tishko0 via 920c332 April 8, 2026 08:33
@dkamburov dkamburov requested a review from MayaKirova April 8, 2026 13:20
@dkamburov dkamburov merged commit c2fb8ac into 20.1.x Apr 9, 2026
5 checks passed
@dkamburov dkamburov deleted the iminchev/elements-cell-activation-20.1.x branch April 9, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants