Skip to content

fix(pivot): Update the default row height if content size changed.#17034

Merged
dkamburov merged 2 commits into21.1.xfrom
mkirova/fix-17020-21.1.x
Apr 8, 2026
Merged

fix(pivot): Update the default row height if content size changed.#17034
dkamburov merged 2 commits into21.1.xfrom
mkirova/fix-17020-21.1.x

Conversation

@MayaKirova
Copy link
Copy Markdown
Contributor

Closes #17020

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copilot AI review requested due to automatic review settings April 7, 2026 10:32
@IMinchev64 IMinchev64 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes pivot grid header/cell misalignment after runtime browser zoom changes by ensuring the grid recalculates layout and (for pivot) updates the default row height when the scroll container content size changes.

Changes:

  • Introduces a protected onContentSizeChange() hook in IgxGridBaseDirective and routes verticalScrollContainer.contentSizeChange through it.
  • Overrides onContentSizeChange() in IgxPivotGridComponent to also call updateDefaultRowHeight() after the base repaint request.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts Overrides the new content-size-change hook to refresh default row height for pivot grids.
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts Adds an overridable onContentSizeChange() hook and uses it for contentSizeChange handling.

@dkamburov dkamburov requested a review from mddragnev April 7, 2026 11:38
@dkamburov dkamburov merged commit de4312f into 21.1.x Apr 8, 2026
9 checks passed
@dkamburov dkamburov deleted the mkirova/fix-17020-21.1.x branch April 8, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: pivot version: 21.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants