fix(grid): Recalculate horizontal size cache when scrolling horizontally with autosized columns ##17427
Open
mddragnev wants to merge 5 commits into
Open
fix(grid): Recalculate horizontal size cache when scrolling horizontally with autosized columns ##17427mddragnev wants to merge 5 commits into
mddragnev wants to merge 5 commits into
Conversation
… size cache rebuilding
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets a Grid horizontal virtualization issue where many width="auto" columns can leave a large blank gap at the end of horizontal scrolling, by ensuring the horizontal size caches are recalculated after auto-sizing columns that enter the viewport.
Changes:
- Trigger cache rebuilds for the header and horizontal
IgxGridForOfDirectiveinstances after auto-sizing columns in view. - Add a unit test intended to validate that the horizontal size cache is rebuilt when navigating horizontally to columns that are auto-sized.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Rebuilds horizontal virtualization size caches after auto-sizing columns in view to prevent stale cached widths during horizontal scroll. |
| projects/igniteui-angular/grids/grid/src/column.spec.ts | Adds a unit test for verifying horizontal size cache behavior when auto-sized columns are scrolled into view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17392
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)