feat(chip): add outlined version - #17452
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
projects/igniteui-angular/chips/src/chips/chip.component.ts:238
- PR description says it closes issue #591, but the referenced issue is about an Avatar ripple overflow, while this PR changes Chip styling/API (outlined variant). Please update the PR description/linked issue(s) so the tracking is accurate (either link the correct chip-related issue or remove the close directive).
/**
* Sets/gets whether the chip is outlined.
* Default value is `false`.
*
* @example
* ```html
* <igx-chip outlined></igx-chip>
* ```
*/
@Input({transform: booleanAttribute})
@HostBinding('class.igx-chip--outlined')
public outlined = false;
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
projects/igniteui-angular/chips/src/chips/chip.component.ts:236
- Decorator formatting is inconsistent with the rest of the file (missing spaces inside the
@Inputoptions object). Keeping the same spacing style improves readability and reduces noisy diffs.
@Input({transform: booleanAttribute})
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
projects/igniteui-angular/core/src/core/styles/components/chip/_chip-theme.scss:941
- In the disabled + outlined indigo branch, the text color uses
contrast-color($color: 'error', ...), which looks like a copy/paste mistake (it applies to primary/info/success/warning/danger chips). This makes disabled outlined chips depend on theerrorpalette unexpectedly.
@if $variant == 'indigo' {
color: if($theme-variant == 'light', color($color: 'gray', $variant: 900), contrast-color($color: 'error', $variant: 900));
background: transparent;
opacity: .4;
projects/igniteui-angular/core/src/core/styles/components/chip/_chip-theme.scss:33
- Same as above for
focus-selected-shadow-color: without a fallback, older theme maps that only definefocus-selected-outline-colorcould generate an invalid box-shadow value.
$box-shadow-focus-selected: map.get((
'material': null,
'fluent': null,
'bootstrap': 0 0 0 rem(4px) var-get($theme, 'focus-selected-shadow-color'),
'indigo': 0 0 0 rem(3px) var-get($theme, 'focus-selected-shadow-color')
projects/igniteui-angular/chips/src/chips/chip.component.ts:236
- Formatting is inconsistent with the surrounding inputs (missing spaces inside the object literal).
@Input({transform: booleanAttribute})
|
Material The Outlined disabled chip for all variants ( Default, Primary, Info, Success, Warning and Danger) shares the same colours as in the Outlined Default Disabled chip: Light Mode: Dark Mode: |
|
Indigo Light Mode
Background color: transparent Indigo Dark Mode
Background color: transparent |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (4)
projects/igniteui-angular/chips/src/chips/chip.component.ts:236
- Keep decorator argument formatting consistent with the rest of the file (spaces after
{and before}) for the newoutlinedinput.
@Input({transform: booleanAttribute})
projects/igniteui-angular/core/src/core/styles/components/chip/_chip-theme.scss:27
focus-shadow-coloris only referenced here in the repo; if the theming token/CSS var name wasn’t introduced alongside this change, Bootstrap/Indigo chips may lose their focus ring. Please confirm the token exists (and is emitted by the theming layer) or keep backward compatibility with the previous token name.
'material': null,
'fluent': null,
'bootstrap': 0 0 0 rem(4px) var-get($theme, 'focus-shadow-color'),
'indigo': 0 0 0 rem(3px) var-get($theme, 'focus-shadow-color')
), $variant);
projects/igniteui-angular/chips/src/chips/chip.component.ts:234
- The PR description indicates it closes IgniteUI/igniteui-theming#591 (avatar ripple behavior), but the code changes here appear focused on adding an
outlinedvariant for chips. Please verify the linked issue/closure reference is correct (or update the PR metadata) so tracking remains accurate.
/**
* Sets/gets whether the chip is outlined.
* Default value is `false`.
*
* @example
* ```html
* <igx-chip outlined></igx-chip>
* ```
src/app/chips/chips.sample.html:53
- The new outlined chip sample block uses inconsistent indentation compared to the existing Angular Chip example above it, which makes the sample harder to read and may fail template formatting/lint expectations.
@if (hasAvatar) {
<igx-avatar
igxPrefix
class="chip-area-avatar"
[shape]="'circle'"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
projects/igniteui-angular/chips/src/chips/chip.component.ts:229
- The PR description links to igniteui-theming issue #591 about igxAvatar ripple spreading across the page, but the changes here add an outlined Chip variant and update Chip styles/tests. This looks like a mismatch in what the PR claims to close/test against; please update the PR description/linked issue(s) (or adjust scope) so tracking and release notes are accurate.
/**
* Sets/gets whether the chip is outlined.
* Default value is `false`.
projects/igniteui-angular/core/src/core/styles/components/chip/_chip-theme.scss:27
- The focus ring token names were changed from
focus-outline-color/focus-selected-outline-colortofocus-shadow-color/focus-selected-shadow-color. This is inconsistent with other component themes (e.g. switch usesfocus-outline-colorfor box-shadow incore/src/core/styles/components/switch/_switch-theme.scss:236,248,258) and may break existing theme overrides/migrations that rely on the old token names.
'material': null,
'fluent': null,
'bootstrap': 0 0 0 rem(4px) var-get($theme, 'focus-shadow-color'),
'indigo': 0 0 0 rem(3px) var-get($theme, 'focus-shadow-color')
), $variant);
projects/igniteui-angular/chips/src/chips/chip.component.ts:235
outlinedis a new public@Input, but the chip README’s Inputs table doesn’t document it yet. Please add it toprojects/igniteui-angular/chips/README.mdso consumers discover the API and the breaking change is clearly communicated.
/**
* Sets/gets whether the chip is outlined.
* Default value is `false`.
*
* @example
* ```html
* <igx-chip outlined></igx-chip>
* ```
*/




Closes #591
Needs to be tested together with this theming PR: #592
The WC implementation is still a work in progress.
Description
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Chip
How Has This Been Tested?
Checklist: