Skip to content

Commit 4d3097c

Browse files
Copilotdamyanpetev
andauthored
fix: address all unresolved review comments on React igr-ts templates
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/2470cb9f-f7c6-4d85-8e9b-f5028c773415 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
1 parent 3aaed12 commit 4d3097c

11 files changed

Lines changed: 22 additions & 12 deletions

File tree

packages/cli/templates/react/igr-ts/accordion/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrAccordionTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["IgrAccordion"];
6+
this.components = ["Accordion"];
77
this.controlGroup = "Layouts";
88
this.listInComponentTemplates = true;
99
this.id = "accordion";

packages/cli/templates/react/igr-ts/card/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrCardTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["IgrCard"];
6+
this.components = ["Card"];
77
this.controlGroup = "Layouts";
88
this.listInComponentTemplates = true;
99
this.id = "card";

packages/cli/templates/react/igr-ts/circular-progress/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrCircularProgressTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["CircularProgress"];
6+
this.components = ["Circular Progress"];
77
this.controlGroup = "Data Entry & Display";
88
this.listInComponentTemplates = true;
99
this.id = "circular-progress";

packages/cli/templates/react/igr-ts/custom-templates/subscription-form/files/src/app/__path__/__filePrefix__.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ import { IgrInput, IgrCheckbox, IgrButton } from 'igniteui-react';
33
import 'igniteui-webcomponents/themes/light/bootstrap.css';
44

55
export default function $(ClassName)() {
6-
const handleSubmit = (event: React.FormEvent<HTMLFormElement>) => {
6+
const handleSubmit = (event: SubmitEvent) => {
77
event.preventDefault();
8-
const formData = new FormData(event.currentTarget);
8+
const form = event.target as HTMLFormElement;
9+
const formData = new FormData(form);
910
const entries = Array.from(formData.entries());
1011
const result = entries.map(([key, value]) => `${key}=${value}`).join('; ');
1112
alert(result);

packages/cli/templates/react/igr-ts/date-picker/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrDatePickerTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["DatePicker"];
6+
this.components = ["Date Picker"];
77
this.controlGroup = "Scheduling";
88
this.listInComponentTemplates = true;
99
this.id = "date-picker";

packages/cli/templates/react/igr-ts/divider/default/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrDividerTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["IgrDivider"];
7-
this.controlGroup = "Layouts";
6+
this.components = ["Divider"];
7+
this.controlGroup = "Data Entry & Display";
88
this.listInComponentTemplates = true;
99
this.id = "divider";
1010
this.projectType = "igr-ts";

packages/cli/templates/react/igr-ts/divider/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ class IgrDividerComponent extends BaseComponent {
44
constructor() {
55
super(__dirname);
66
this.name = "Divider";
7-
this.group = "Layouts";
7+
this.group = "Data Entry & Display";
88
this.description = `provides a thin, lightweight separator.`;
99
}
1010
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
:local(.container) {
2+
padding-top: 24px;
3+
display: flex;
4+
flex-flow: row;
5+
justify-content: space-around;
6+
}
7+
:local(.title) {
8+
color: rgb(0, 153, 255);
9+
}

packages/cli/templates/react/igr-ts/expansion-panel/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrExpansionPanelTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["IgrExpansionPanel"];
6+
this.components = ["Expansion Panel"];
77
this.controlGroup = "Layouts";
88
this.listInComponentTemplates = true;
99
this.id = "expansion-panel";

packages/cli/templates/react/igr-ts/linear-progress/default/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IgniteUIForReactTemplate } from "../../../../../lib/templates/IgniteUIF
33
class IgrLinearProgressTemplate extends IgniteUIForReactTemplate {
44
constructor() {
55
super(__dirname);
6-
this.components = ["LinearProgress"];
6+
this.components = ["Linear Progress"];
77
this.controlGroup = "Data Entry & Display";
88
this.listInComponentTemplates = true;
99
this.id = "linear-progress";

0 commit comments

Comments
 (0)