Merge branch 'master' into copilot/refactor-side-navigation-auth-template

Author: Hristo313

.vscode/settings.json

@@ -18,9 +18,5 @@
 		"migrations/**/*.js": {"when": "$(basename).ts"},
 		"schematics/**/*.js.map": true,
 		"schematics/**/*.js": {"when": "$(basename).ts"}
-	},
-	"tslint.exclude": [ 
-		"**/files/**/*.ts",
-		"./output/**/*.ts"
-	]
+	}
 }

eslint.config.mjs

@@ -32,7 +32,6 @@ export default [
     rules: {
       'complexity': 'off',
       'eslint-plugin-import/no-extraneous-dependencies': 'warn',
-      'eslint-plugin-import/no-internal-modules': 'warn',
       'eslint-plugin-import/order': [
         'off',
         {
@@ -93,7 +92,7 @@ export default [
       'no-bitwise': 'off',
       'no-caller': 'error',
       'no-cond-assign': 'error',
-      'no-console': 'off',
+      'no-console': 'error',
       'no-debugger': 'error',
       'no-duplicate-case': 'error',
       'no-duplicate-imports': 'error',
@@ -132,12 +131,19 @@ export default [
       'valid-typeof': 'off',
     },
   },
+  {
+    files: ['**/*.spec.ts', '**/*-spec.ts', 'spec/**/*.ts'],
+    rules: {
+      'eslint-plugin-import/no-extraneous-dependencies': 'off',
+      'no-console': 'off',
+    },
+  },
   {
     ignores: [
-      '/node_modules/**/*',
-      '/coverage/**/*',
-      '/output/**/*',
-      '/packages/cli/templates/**/*',
+      'node_modules/**/*',
+      'coverage/**/*',
+      'output/**/*',
+      'packages/cli/templates/**/*',
       '**/files/**/*'
     ]
   },

package.json

@@ -83,7 +83,6 @@
 		"resolve": "^1.22.8",
 		"source-map-support": "^0.5.21",
 		"ts-node": "^10.9.2",
-		"tslint": "^5.11.0",
 		"typescript": "~5.6.2",
 		"typescript-json-schema": "^0.65.1"
 	},

packages/cli/lib/PromptSession.ts

@@ -95,9 +95,7 @@ export class PromptSession extends BasePromptSession {
 
 	protected async completeAndRun(port?: number) {
 		await PackageManager.flushQueue(true);
-		if (true) { // TODO: Make conditional?
-			await start.start({ port });
-		}
+		await start.start({ port });
 	}
 
 	protected async upgradePackages() {

packages/cli/lib/commands/generate.ts

@@ -79,7 +79,6 @@ const command: CommandType = {
 	command: "generate",
 	describe: "generates custom template",
 	templateManager: null,
-	// tslint:disable:object-literal-sort-keys
 	builder: yargs => {
 		yargs
 			.command({

packages/cli/lib/templates/jQueryTemplate.ts

@@ -5,7 +5,6 @@ import * as path from "path";
 /**
  * Template with specific implementation for jQuery projects
  */
-// tslint:disable-next-line:class-name
 export class jQueryTemplate implements Template {
 	public components: string[];
 	public controlGroup: string;
@@ -90,7 +89,6 @@ export class jQueryTemplate implements Template {
 		return builder;
 	}
 	protected getScriptTags(): string {
-		// tslint:disable-next-line:no-submodule-imports
 		const config = require("@igniteui/cli-core/packages/components");
 		let builder = "";
 		builder += this.getJqueryDependenciesScriptTag();

packages/cli/migrations/update-13_1_0/index.spec.ts

@@ -1,7 +1,5 @@
 import * as path from "path";
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 13.1.0", () => {

packages/cli/migrations/update-13_1_0/index.ts

@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 
 export default function(options: any): Rule {

packages/cli/migrations/update-2/index.spec.ts

@@ -1,8 +1,6 @@
 import * as path from "path";
 
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 2.0.0", () => {

packages/cli/migrations/update-2/index.ts

@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 
 export default function(): Rule {