chore: cleanup all leftover references to tslint (#1558)

damyanpetev · web-flow · commit 78c564718684 · 2026-03-20T17:11:27.000+02:00
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -18,9 +18,5 @@
 		"migrations/**/*.js": {"when": "$(basename).ts"},
 		"schematics/**/*.js.map": true,
 		"schematics/**/*.js": {"when": "$(basename).ts"}
-	},
-	"tslint.exclude": [ 
-		"**/files/**/*.ts",
-		"./output/**/*.ts"
-	]
+	}
 }
diff --git a/package.json b/package.json
@@ -83,7 +83,6 @@
 		"resolve": "^1.22.8",
 		"source-map-support": "^0.5.21",
 		"ts-node": "^10.9.2",
-		"tslint": "^5.11.0",
 		"typescript": "~5.6.2",
 		"typescript-json-schema": "^0.65.1"
 	},
diff --git a/packages/cli/lib/commands/generate.ts b/packages/cli/lib/commands/generate.ts
@@ -79,7 +79,6 @@ const command: CommandType = {
 	command: "generate",
 	describe: "generates custom template",
 	templateManager: null,
-	// tslint:disable:object-literal-sort-keys
 	builder: yargs => {
 		yargs
 			.command({
diff --git a/packages/cli/lib/templates/jQueryTemplate.ts b/packages/cli/lib/templates/jQueryTemplate.ts
@@ -5,7 +5,6 @@ import * as path from "path";
 /**
  * Template with specific implementation for jQuery projects
  */
-// tslint:disable-next-line:class-name
 export class jQueryTemplate implements Template {
 	public components: string[];
 	public controlGroup: string;
@@ -90,7 +89,6 @@ export class jQueryTemplate implements Template {
 		return builder;
 	}
 	protected getScriptTags(): string {
-		// tslint:disable-next-line:no-submodule-imports
 		const config = require("@igniteui/cli-core/packages/components");
 		let builder = "";
 		builder += this.getJqueryDependenciesScriptTag();
diff --git a/packages/cli/migrations/update-13_1_0/index.spec.ts b/packages/cli/migrations/update-13_1_0/index.spec.ts
@@ -1,7 +1,5 @@
 import * as path from "path";
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 13.1.0", () => {
diff --git a/packages/cli/migrations/update-13_1_0/index.ts b/packages/cli/migrations/update-13_1_0/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 
 export default function(options: any): Rule {
diff --git a/packages/cli/migrations/update-2/index.spec.ts b/packages/cli/migrations/update-2/index.spec.ts
@@ -1,8 +1,6 @@
 import * as path from "path";
 
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 2.0.0", () => {
diff --git a/packages/cli/migrations/update-2/index.ts b/packages/cli/migrations/update-2/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 
 export default function(): Rule {
diff --git a/packages/cli/migrations/update-3/index.spec.ts b/packages/cli/migrations/update-3/index.spec.ts
@@ -1,8 +1,5 @@
 import * as path from "path";
-
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 3.0.0", () => {
diff --git a/packages/cli/migrations/update-3/index.ts b/packages/cli/migrations/update-3/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 import { addClassToBody, Config } from "@igniteui/cli-core";
 
diff --git a/packages/cli/migrations/update-3_2/index.spec.ts b/packages/cli/migrations/update-3_2/index.spec.ts
@@ -1,8 +1,5 @@
 import * as path from "path";
-
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 3.2.0", () => {
diff --git a/packages/cli/migrations/update-3_2/index.ts b/packages/cli/migrations/update-3_2/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { workspaces } from "@angular-devkit/core";
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 import { createWorkspaceHost } from "@igniteui/cli-core";
diff --git a/packages/cli/migrations/update-4_2_3/index.spec.ts b/packages/cli/migrations/update-4_2_3/index.spec.ts
@@ -1,8 +1,5 @@
 import * as path from "path";
-
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 4.2.3", () => {
diff --git a/packages/cli/migrations/update-4_2_3/index.ts b/packages/cli/migrations/update-4_2_3/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { workspaces } from "@angular-devkit/core";
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 import { createWorkspaceHost } from "@igniteui/cli-core";
diff --git a/packages/cli/migrations/update-5_0_0/index.spec.ts b/packages/cli/migrations/update-5_0_0/index.spec.ts
@@ -1,8 +1,5 @@
 import * as path from "path";
-
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 5.0.0", () => {
diff --git a/packages/cli/migrations/update-5_0_0/index.ts b/packages/cli/migrations/update-5_0_0/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { workspaces } from "@angular-devkit/core";
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 import { App, createWorkspaceHost, FS_TOKEN, FS_TYPE_TOKEN, FsTypes, IFileSystem, TypeScriptUtils } from "@igniteui/cli-core";
diff --git a/packages/cli/migrations/update-5_0_3/index.spec.ts b/packages/cli/migrations/update-5_0_3/index.spec.ts
@@ -1,8 +1,5 @@
 import * as path from "path";
-
-// tslint:disable:no-implicit-dependencies
 import { EmptyTree } from "@angular-devkit/schematics";
-// tslint:disable-next-line:no-submodule-imports
 import { SchematicTestRunner, UnitTestTree } from "@angular-devkit/schematics/testing";
 
 describe("Update 5.0.0", () => {
diff --git a/packages/cli/migrations/update-5_0_3/index.ts b/packages/cli/migrations/update-5_0_3/index.ts
@@ -1,4 +1,3 @@
-// tslint:disable:no-implicit-dependencies
 import { workspaces } from "@angular-devkit/core";
 import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
 import { createWorkspaceHost } from "@igniteui/cli-core";
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -21,16 +21,6 @@
     "url": "https://github.com/IgniteUI/igniteui-cli/issues"
   },
   "main": "lib/cli.js",
-  "scripts": {
-    "build": "node ./node_modules/typescript/lib/tsc.js && npm run config-schema",
-    "build-pack": "node ./node_modules/typescript/lib/tsc.js -p tsconfig-pack.json && npm run config-schema",
-    "pretest": "npm run lint && npm run build",
-    "test": "nyc npm run jasmine",
-    "jasmine": "node spec/jasmine-runner.js",
-    "coverage": "nyc report --reporter=text-lcov | coveralls",
-    "lint": "tslint --project tsconfig.json",
-    "config-schema": "typescript-json-schema packages/core/types/Config.ts Config -o packages/core/config/Config.schema.json"
-  },
   "files": [
     "ignite-ui-cli.txt",
     "bin/*",
@@ -102,7 +92,6 @@
     "rxjs": "~7.8.1",
     "source-map-support": "^0.5.21",
     "ts-node": "~10.9.2",
-    "tslint": "~6.1.0",
     "typescript-json-schema": "^0.65.1"
   },
   "ng-update": {
diff --git a/packages/cli/scripts/install.ts b/packages/cli/scripts/install.ts
@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import { App, GoogleAnalytics } from "@igniteui/cli-core";
 
 function install() {
diff --git a/packages/cli/scripts/uninstall.ts b/packages/cli/scripts/uninstall.ts
@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import { App, GoogleAnalytics } from "@igniteui/cli-core";
 
 function uninstall() {
diff --git a/packages/cli/templates/jquery/index.ts b/packages/cli/templates/jquery/index.ts
@@ -1,6 +1,5 @@
 import { Framework, ProjectLibrary } from "@igniteui/cli-core";
 
-// tslint:disable-next-line:class-name
 class jQueryFramework implements Framework {
 	public id: string;
 	public name: string;
diff --git a/packages/cli/templates/jquery/js/hierarchical-grid/hierarchical-grid/index.ts b/packages/cli/templates/jquery/js/hierarchical-grid/hierarchical-grid/index.ts
@@ -35,7 +35,6 @@ class HierarchicalGridTemplate extends jQueryTemplate {
 		this.userExtraConfiguration = extraConfigKeys;
 	}
 	public generateConfig(name: string, ...options: any[]): {[key: string]: any} {
-		// tslint:disable:object-literal-sort-keys
 		this.gridHelper.addFeature("Responsive", {
 			inherit: false,
 			enableVerticalRendering: false,
@@ -54,7 +53,7 @@ class HierarchicalGridTemplate extends jQueryTemplate {
 				}
 			]
 		});
-		// tslint:enable:object-literal-sort-keys
+
 		const features = this.gridHelper.generateFeatures(this.userExtraConfiguration["features"], 4);
 		const config = { gridfeatures: features };
 		return super.generateConfig(name, { extraConfig : config });
diff --git a/packages/cli/templates/jquery/js/index.ts b/packages/cli/templates/jquery/js/index.ts
@@ -1,6 +1,4 @@
 import { BaseProjectLibrary } from "@igniteui/cli-core";
-
-// tslint:disable-next-line:class-name
 class jQueryJSProjectLibrary extends BaseProjectLibrary {
 	/**
 	 *
@@ -14,7 +12,7 @@ class jQueryJSProjectLibrary extends BaseProjectLibrary {
 		this._customTemplatesPath = "custom-templates";
 
 		const groups = require("./groups.json");
-		// tslint:disable-next-line:forin
+
 		for (const key in groups) {
 			this.groupDescriptions.set(key, groups[key]);
 		}
diff --git a/packages/cli/templates/react/igr-ts/index.ts b/packages/cli/templates/react/igr-ts/index.ts
@@ -8,7 +8,6 @@ class IgrTsReactProjectLibrary extends BaseProjectLibrary {
 		this.themes = ["default"];
 
 		const groups = require("./groups.json");
-		// tslint:disable-next-line:forin
 		for (const key in groups) {
 			this.groupDescriptions.set(key, groups[key]);
 		}
diff --git a/packages/core/packages/PackageManager.ts b/packages/core/packages/PackageManager.ts
@@ -140,7 +140,6 @@ export class PackageManager {
 				break;
 		}
 		try {
-			// tslint:disable-next-line:object-literal-sort-keys
 			Util.execSync(command, { stdio: "pipe", encoding: "utf8" });
 		} catch (error) {
 			Util.log(`Error uninstalling package ${sanitizePackage} with ${managerCommand}`);
@@ -159,7 +158,6 @@ export class PackageManager {
 		const sanitizePackage = Util.sanitizeShellArg(packageName);
 		const command = this.getInstallCommand(managerCommand, sanitizePackage);
 		try {
-			// tslint:disable-next-line:object-literal-sort-keys
 			Util.execSync(command, { stdio: "pipe", encoding: "utf8" });
 		} catch (error) {
 			Util.log(`Error installing package ${sanitizePackage} with ${managerCommand}`);
@@ -233,7 +231,6 @@ export class PackageManager {
 	public static ensureRegistryUser(config: Config, message: string): boolean {
 		const fullPackageRegistry = Util.sanitizeShellArg(config.igPackageRegistry);
 		try {
-			// tslint:disable-next-line:object-literal-sort-keys
 			Util.execSync(`npm whoami --registry=${fullPackageRegistry}`, { stdio: "pipe", encoding: "utf8" });
 		} catch (error) {
 			if (!REGISTRY_ATTEMPT_LOGIN) {
diff --git a/packages/core/typescript/TypeScriptUtils.ts b/packages/core/typescript/TypeScriptUtils.ts
@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import * as ts from "typescript";
 import { FS_TOKEN, IFileSystem } from "../types/FileSystem";
 import { App } from "../util";
diff --git a/packages/core/util/GoogleAnalytics.ts b/packages/core/util/GoogleAnalytics.ts
@@ -162,7 +162,7 @@ class GoogleAnalytics {
 		if (!this.npmVersion) {
 			this.npmVersion = "";
 			const buffer = Util.execSync("npm -v");
-			// tslint:disable-next-line:prefer-for-of
+
 			for (let i = 0; i < buffer.length; i += 1) {
 				this.npmVersion += String.fromCharCode(+buffer[i]).toString();
 			}
diff --git a/packages/core/util/Util.ts b/packages/core/util/Util.ts
@@ -110,7 +110,6 @@ export class Util {
 
 	public static applyConfigTransformation = (data: string, configuration: { [key: string]: string }): string => {
 		let key;
-		// tslint:disable-next-line:forin
 		for (key in configuration) {
 			data = data.replace(new RegExp(Util.escapeRegExp(key), "g"), configuration[key]);
 		}
diff --git a/packages/ng-schematics/scripts/install.ts b/packages/ng-schematics/scripts/install.ts
@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import { App, GoogleAnalytics } from "@igniteui/cli-core";
 
 function install() {
diff --git a/packages/ng-schematics/scripts/uninstall.ts b/packages/ng-schematics/scripts/uninstall.ts
@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import { App, GoogleAnalytics } from "@igniteui/cli-core";
 
 function uninstall() {
diff --git a/packages/ng-schematics/src/cli-config/index.ts b/packages/ng-schematics/src/cli-config/index.ts
@@ -117,7 +117,6 @@ function importStyles(): Rule {
 	};
 }
 
-// tslint:disable-next-line:space-before-function-paren
 export default function (): Rule {
 	return (tree: Tree) => {
 		setVirtual(tree);
diff --git a/packages/ng-schematics/src/cli-config/index_spec.ts b/packages/ng-schematics/src/cli-config/index_spec.ts
@@ -9,7 +9,7 @@ describe("cli-config schematic", () => {
 	const runner: SchematicTestRunner = new SchematicTestRunner("cli-schematics", collectionPath);
 	let tree: UnitTestTree;
 	const sourceRoot = "src";
-	// tslint:disable: object-literal-sort-keys
+
 	const ngJsonConfig = {
 		projects: {
 			testProj: {
diff --git a/packages/ng-schematics/src/ng-new/index_spec.ts b/packages/ng-schematics/src/ng-new/index_spec.ts
@@ -139,7 +139,6 @@ describe("Schematics ng-new", () => {
 			expect(e.files.length).toEqual(1);
 			expect(e.exists(`${workingDirectory}/.gitignore`)).toBeTruthy();
 			const taskOptions = runner.tasks.map(task => task.options);
-			// tslint:disable:object-literal-sort-keys
 			const expectedInstall: NodePackageTaskOptions = {
 				command: "install",
 				quiet: true,
@@ -193,7 +192,6 @@ describe("Schematics ng-new", () => {
 			expect(e.files.length).toEqual(1);
 			expect(e.exists(`${workingDirectory}/.gitignore`)).toBeTruthy();
 			const taskOptions = runner.tasks.map(task => task.options);
-			// tslint:disable:object-literal-sort-keys
 			const expectedInstall: NodePackageTaskOptions = {
 				command: "install",
 				quiet: true,
diff --git a/packages/ng-schematics/src/tslint.json b/packages/ng-schematics/src/tslint.json
diff --git a/packages/ng-schematics/src/upgrade-packages/index.spec.ts b/packages/ng-schematics/src/upgrade-packages/index.spec.ts
@@ -7,7 +7,6 @@ import { SchematicsTemplateManager } from "../SchematicsTemplateManager";
 import { NgTreeFileSystem } from "../utils/NgFileSystem";
 
 describe("Schematics upgrade-packages", () => {
-	// tslint:disable: object-literal-sort-keys
 
 	let appTree: UnitTestTree;
 	const collectionPath = path.join(__dirname, "../collection.json");
diff --git a/scripts/build-task.ts b/scripts/build-task.ts
@@ -5,10 +5,8 @@ const scripts = {
 	preuninstall: "node ./scripts/uninstall.js"
 };
 
-// tslint:disable-next-line:no-var-requires
 const config = require("../packages/cli/package.json");
 config.scripts = scripts;
-// tslint:disable-next-line:no-var-requires
 const schematicsConfig = require("../packages/ng-schematics/package.json");
 Object.assign(schematicsConfig.scripts, scripts);
 
diff --git a/spec/acceptance/add-spec.ts b/spec/acceptance/add-spec.ts
diff --git a/spec/templates/angular-spec.ts b/spec/templates/angular-spec.ts
diff --git a/spec/templates/jquery-spec.ts b/spec/templates/jquery-spec.ts
diff --git a/spec/templates/react-spec.ts b/spec/templates/react-spec.ts
diff --git a/spec/unit/BaseProjectLibrary-spec.ts b/spec/unit/BaseProjectLibrary-spec.ts
diff --git a/spec/unit/PromptSession-spec.ts b/spec/unit/PromptSession-spec.ts
diff --git a/spec/unit/TemplateManager-spec.ts b/spec/unit/TemplateManager-spec.ts
diff --git a/spec/unit/add-spec.ts b/spec/unit/add-spec.ts
diff --git a/spec/unit/config-spec.ts b/spec/unit/config-spec.ts
diff --git a/spec/unit/generate-spec.ts b/spec/unit/generate-spec.ts
diff --git a/spec/unit/start-spec.ts b/spec/unit/start-spec.ts
diff --git a/spec/unit/ts-transform/TypeScriptUtils-spec.ts b/spec/unit/ts-transform/TypeScriptUtils-spec.ts
diff --git a/spec/unit/update-spec.ts b/spec/unit/update-spec.ts
diff --git a/spec/unit/upgrade-spec.ts b/spec/unit/upgrade-spec.ts
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// tslint:disable:no-implicit-dependencies`
`2`	`1`	`import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics";`
`3`	`2`
`4`	`3`	`export default function(options: any): Rule {`