refactor(upgrade-packages): always keep igniteui-react; upgrade igniteui-react-dockmanager instead (#1638)

Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -89,6 +89,7 @@ A comprehensive modernization of all Angular templates to align with Angular v21
 * **CLI error handling:** added `.fail()` handler to yargs to gracefully handle command validation errors (e.g., missing required subcommands) instead of showing raw stack traces ([#1614](https://github.com/IgniteUI/igniteui-cli/pull/1614))
 * **Unknown command detection:** running `ig <unknown>` now prints an error message and available commands instead of silently falling through to the step-by-step interactive mode ([#1614](https://github.com/IgniteUI/igniteui-cli/pull/1614))
 * **Unhandled promise rejection:** added `.catch()` in the CLI entry point to catch and display unexpected errors cleanly ([#1614](https://github.com/IgniteUI/igniteui-cli/pull/1614))
+* **upgrade-packages:** aligned with React 19.4.0+ licensing migration, now upgrading `igniteui-react-dockmanager` and no longer upgrading `igniteui-react` ([#1641](https://github.com/IgniteUI/igniteui-cli/pull/1641))
 
 ---
 

packages/core/update/package-resolve.ts

@@ -16,7 +16,8 @@ export const FEED_DOCK_MANAGER = "@infragistics/igniteui-dockmanager";
 
 // react
 export const NPM_REACT = "igniteui-react";
-export const FEED_REACT = "@infragistics/igniteui-react";
+export const NPM_REACT_DOCK_MANAGER = "igniteui-react-dockmanager";
+export const FEED_REACT_DOCK_MANAGER = "@infragistics/igniteui-react-dockmanager";
 export const NPM_REACT_CORE = "igniteui-react-core";
 export const FEED_REACT_CORE = "@infragistics/igniteui-react-core";
 export const NPM_REACT_CHARTS = "igniteui-react-charts";
@@ -76,7 +77,7 @@ export const UPGRADEABLE_PACKAGES = {
 	[NPM_DOCK_MANAGER]: FEED_DOCK_MANAGER,
 
 	// react
-	[NPM_REACT]: FEED_REACT,
+	[NPM_REACT_DOCK_MANAGER]: FEED_REACT_DOCK_MANAGER,
 	[NPM_REACT_CORE]: FEED_REACT_CORE,
 	[NPM_REACT_CHARTS]: FEED_REACT_CHARTS,
 	[NPM_REACT_GAUGES]: FEED_REACT_GAUGES,

spec/unit/packageResolve-spec.ts

@@ -2,7 +2,8 @@ import { IFileSystem } from "../../packages/core/types";
 import { App } from "../../packages/core/util";
 import {
 	FEED_DOCK_MANAGER, FEED_ANGULAR, getUpgradeablePackages,
-	NPM_DOCK_MANAGER, NPM_ANGULAR, resolvePackage, PackageDefinition
+	NPM_DOCK_MANAGER, NPM_ANGULAR, resolvePackage, PackageDefinition,
+	FEED_REACT_DOCK_MANAGER, NPM_REACT_DOCK_MANAGER
 } from "../../packages/core/update/package-resolve";
 
 class MockFileSystem implements IFileSystem {
@@ -114,6 +115,15 @@ describe("Igx templates - package resolve", () => {
 			expected.push({ trial: NPM_DOCK_MANAGER, licensed: FEED_DOCK_MANAGER });
 			mockRead.and.returnValue(JSON.stringify(mockObj));
 			expect(getUpgradeablePackages()).toEqual(expected);
+			mockObj.dependencies = {
+				"igniteui-angular": "^9.0.1",
+				"igniteui-dockmanager": "0.1.0",
+				"igniteui-react-dockmanager": "0.1.0",
+				"kek": "1.0.1"
+			};
+			expected.push({ trial: NPM_REACT_DOCK_MANAGER, licensed: FEED_REACT_DOCK_MANAGER });
+			mockRead.and.returnValue(JSON.stringify(mockObj));
+			expect(getUpgradeablePackages()).toEqual(expected);
 		});
 	});
 });

spec/unit/update-spec.ts

@@ -483,8 +483,8 @@ title = 'igniteui-angular example';
 
 		it("Should fail if no packages.json is found", async () => {
 			const upgradeable: pkgResolve.PackageDefinition = {
-				trial: pkgResolve.NPM_REACT,
-				licensed: pkgResolve.FEED_REACT
+				trial: pkgResolve.NPM_REACT_DOCK_MANAGER,
+				licensed: pkgResolve.FEED_REACT_DOCK_MANAGER
 			};
 			spyOn(pkgResolve, "getUpgradeablePackages").and.returnValue([upgradeable]);
 			(fsSpy.directoryExists as jasmine.Spy).and.returnValue(false);
@@ -499,8 +499,8 @@ title = 'igniteui-angular example';
 				someName: "testValue"
 			};
 			const upgradeable: pkgResolve.PackageDefinition = {
-				trial: pkgResolve.NPM_REACT,
-				licensed: pkgResolve.FEED_REACT
+				trial: pkgResolve.NPM_REACT_DOCK_MANAGER,
+				licensed: pkgResolve.FEED_REACT_DOCK_MANAGER
 			};
 			spyOn(pkgResolve, "getUpgradeablePackages").and.returnValue([upgradeable]);
 			(fsSpy.directoryExists as jasmine.Spy).and.returnValue(false);
@@ -509,13 +509,14 @@ title = 'igniteui-angular example';
 			expect(await updateWorkspace("")).toEqual(false);
 		});
 
-		it("Should update package.json file, removing non-scoped igniteui-react packages", async () => {
+		it("Should update package.json file, removing non-scoped igniteui-react-* packages", async () => {
 			const mockPackageJSON = {
 				dependencies: {
 					"@alphabetically-sorted-scope/package": "^0.0.0",
 					"alphabetically-second-package": "^0.0.0",
 					"igniteui-react": "^18.5.1",
-					"igniteui-dockmanager": "^1.0.0",
+					"igniteui-react-grids": "^18.5.1",
+					"igniteui-react-dockmanager": "^1.0.0",
 					"some-package": "^0.0.0"
 				}
 			};
@@ -539,9 +540,10 @@ title = 'igniteui-angular example';
 			expect(fsSpy.writeFile).toHaveBeenCalledWith("package.json", Util.formatPackageJson({
 				dependencies: {
 					"@alphabetically-sorted-scope/package": "^0.0.0",
-					"@infragistics/igniteui-react": "^18.5.1",
-					"@infragistics/igniteui-dockmanager": "^1.0.0",
+					"@infragistics/igniteui-react-dockmanager": "^1.0.0",
+					"@infragistics/igniteui-react-grids": "^18.5.1",
 					"alphabetically-second-package": "^0.0.0",
+					"igniteui-react": "^18.5.1",
 					"some-package": "^0.0.0"
 				}
 			}));
@@ -567,8 +569,8 @@ title = 'igniteui-angular example';
 					`{
   "dependencies": {
     "@infragistics/igniteui-dockmanager": "^1.0.0",
-    "@infragistics/igniteui-react": "^18.5.1",
     "@infragistics/igniteui-react-grids": "^18.5.1",
+    "igniteui-react": "^18.5.1",
     "some-package": "^0.0.0"
   }
 }
@@ -738,8 +740,8 @@ export default function Home() {
   "name": "root-project",
   "dependencies": {
     "@infragistics/igniteui-dockmanager": "^1.0.0",
-    "@infragistics/igniteui-react": "^18.5.1",
     "@infragistics/igniteui-react-grids": "^18.5.1",
+    "igniteui-react": "^18.5.1",
     "some-package": "^0.0.0"
   },
   "workspaces": [
@@ -766,8 +768,8 @@ export default function Home() {
   "name": "charts-project",
   "dependencies": {
     "@infragistics/igniteui-dockmanager": "^1.0.0",
-    "@infragistics/igniteui-react": "^18.5.1",
     "@infragistics/igniteui-react-grids": "^18.5.1",
+    "igniteui-react": "^18.5.1",
     "some-package": "^0.0.0"
   }
 }
@@ -791,8 +793,8 @@ export default function Home() {
   "name": "charts-project",
   "dependencies": {
     "@infragistics/igniteui-dockmanager": "^1.0.0",
-    "@infragistics/igniteui-react": "^18.5.1",
     "@infragistics/igniteui-react-grids": "^18.5.1",
+    "igniteui-react": "^18.5.1",
     "some-package": "^0.0.0"
   }
 }