fix(packages): login command for node@24+ spawn change

Author: damyanpetev

packages/core/packages/PackageManager.ts

@@ -248,20 +248,16 @@ export class PackageManager {
 			if (process.stdin.isTTY) {
 				process.stdin.setRawMode(true);
 			}
-			const cmd = /^win/.test(process.platform) ? "npm.cmd" : "npm"; //https://github.com/nodejs/node/issues/3675
-			const login = Util.spawnSync(cmd,
-				["adduser", `--registry=${fullPackageRegistry}`, `--scope=@infragistics`, `--auth-type=legacy`],
-				{ stdio: "inherit" }
-			);
-			if (login?.status === 0) {
+
+			try {
+				Util.execSync(
+					`npm login --registry=${fullPackageRegistry} --scope=@infragistics --auth-type=legacy`,
+					{ stdio: "inherit" }
+				);
 				//make sure scope is configured:
-				try {
-					Util.execSync(`npm config set @infragistics:registry ${fullPackageRegistry}`);
-					return true;
-				} catch (error) {
-					return false;
-				}
-			} else {
+				Util.execSync(`npm config set @infragistics:registry ${fullPackageRegistry}`);
+				return true;
+			} catch (error) {
 				Util.log(message, "red");
 				return false;
 			}

packages/core/util/Util.ts

@@ -365,14 +365,15 @@ export class Util {
 	/**
 	 * Execute synchronous command with options using spawnSync
 	 * @param command Command to be executed
-	 * NOTE: `spawn` without `shell` (unsafe) is **not** equivalent to `exec` & requires `npm.cmd` to run the correct process on win
-	 * do not call with/add commands that are not known binaries without validating first
+	 * NOTE: `spawn` without `shell` (unsafe) is **not** equivalent to `exec` & requires direct path to run the correct process on win,
+	 * e.g. `npm.cmd` but that is also blocked in node@24+ for security reasons
+	 * Do not call with/add commands that are not known binaries without validating first
 	 * @param args Command arguments
 	 * @param options Command options
 	 * @returns {SpawnSyncReturns} object with status and stdout
 	 * @remarks Consuming code MUST handle the result and check for failure status!
 	 */
-	public static spawnSync(command: string, args: string[], options?: Omit<SpawnSyncOptions, 'shell'>) {
+	public static spawnSync(command: 'node' | 'git', args: string[], options?: Omit<SpawnSyncOptions, 'shell'>) {
 		return spawnSync(command, args, options);
 	}
 

spec/unit/packageManager-spec.ts

@@ -45,14 +45,6 @@ describe("Unit - Package Manager", () => {
 			}
 			return "";
 		});
-		spyOn(Util, "spawnSync").and.returnValues({
-			status: 0,
-			pid: 0,
-			output: [],
-			stdout: "",
-			stderr: "",
-			signal: "SIGABRT"
-		});
 		spyOn(Util, "log");
 		spyOn(PackageManager, "removePackage");
 		await PackageManager.ensureIgniteUISource(true, mockTemplateMgr, true);
@@ -75,9 +67,8 @@ describe("Unit - Package Manager", () => {
 			"yellow"
 		);
 		expect(path.join).toHaveBeenCalled();
-		expect(Util.spawnSync).toHaveBeenCalledWith(
-			/^win/.test(process.platform) ? "npm.cmd" : "npm",
-			["adduser", `--registry=trial`, `--scope=@infragistics`, `--auth-type=legacy`],
+		expect(Util.execSync).toHaveBeenCalledWith(
+			"npm login --registry=trial --scope=@infragistics --auth-type=legacy",
 			{
 				stdio: "inherit"
 			}
@@ -119,14 +110,6 @@ describe("Unit - Package Manager", () => {
 		spyOn(Util, "log");
 		spyOn(TestPackageManager, "removePackage");
 		spyOn(TestPackageManager, "getPackageJSON").and.callFake(() => mockRequire);
-		spyOn(Util, "spawnSync").and.returnValues({
-			status: 1,
-			pid: 0,
-			output: [],
-			stdout: "",
-			stderr: "",
-			signal: "SIGABRT"
-		});
 		await TestPackageManager.ensureIgniteUISource(true, mockTemplateMgr, true);
 		expect(ProjectConfig.localConfig).toHaveBeenCalled();
 		expect(Util.log).toHaveBeenCalledTimes(12);
@@ -162,14 +145,13 @@ describe("Unit - Package Manager", () => {
 			`for instructions on how to install the full package.`,
 			"yellow"
 		); // x1
-		expect(Util.spawnSync).toHaveBeenCalledWith(
-			/^win/.test(process.platform) ? "npm.cmd" : "npm",
-			["adduser", `--registry=trial`, `--scope=@infragistics`, `--auth-type=legacy`],
+		expect(Util.execSync).toHaveBeenCalledWith(
+			"npm login --registry=trial --scope=@infragistics --auth-type=legacy",
 			{
 				stdio: "inherit"
 			}
 		);
-		expect(Util.execSync).toHaveBeenCalledTimes(2);
+		expect(Util.execSync).toHaveBeenCalledTimes(4 /* ¯\(°_o)/¯*/);
 		expect(Util.execSync).toHaveBeenCalledWith(`npm whoami --registry=trial`, { stdio: "pipe", encoding: "utf8" });
 	});
 	it("ensureIgniteUISource - Should run through properly when install now is set to false", async () => {