Skip to content

Commit ec63959

Browse files
authored
fix(igx-ts): fix eslint configurations (#1509)
1 parent 6b4e1c8 commit ec63959

7 files changed

Lines changed: 68 additions & 96 deletions

File tree

packages/igx-templates/igx-ts-legacy/projects/_base/files/angular.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
"lint": {
119119
"builder": "@angular-eslint/builder:lint",
120120
"options": {
121-
"eslintConfig": "eslint.config.mjs",
121+
"eslintConfig": "eslint.config.js",
122122
"lintFilePatterns": [
123123
"src/**/*.ts",
124124
"src/**/*.html"
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
// @ts-check
2+
const eslint = require("@eslint/js");
3+
const { defineConfig } = require("eslint/config");
4+
const tseslint = require("typescript-eslint");
5+
const angular = require("angular-eslint");
6+
7+
module.exports = defineConfig([
8+
{
9+
files: ["**/*.ts"],
10+
extends: [
11+
eslint.configs.recommended,
12+
tseslint.configs.recommended,
13+
tseslint.configs.stylistic,
14+
angular.configs.tsRecommended,
15+
],
16+
processor: angular.processInlineTemplates,
17+
rules: {
18+
"@angular-eslint/directive-selector": [
19+
"error",
20+
{
21+
type: "attribute",
22+
prefix: "app",
23+
style: "camelCase",
24+
},
25+
],
26+
"@angular-eslint/component-selector": [
27+
"error",
28+
{
29+
type: "element",
30+
prefix: "app",
31+
style: "kebab-case",
32+
},
33+
],
34+
// Relax rules
35+
"@typescript-eslint/no-explicit-any": "off",
36+
"@angular-eslint/prefer-inject": "off",
37+
"@angular-eslint/prefer-standalone": "off"
38+
},
39+
},
40+
{
41+
files: ["**/*.html"],
42+
extends: [
43+
angular.configs.templateRecommended
44+
],
45+
rules: {
46+
// Relax rules
47+
"@angular-eslint/template/eqeqeq": "off"
48+
},
49+
}
50+
]);

packages/igx-templates/igx-ts-legacy/projects/_base/files/eslint.config.mjs

Lines changed: 0 additions & 55 deletions
This file was deleted.

packages/igx-templates/igx-ts-legacy/projects/_base/files/package.json

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,27 +29,19 @@
2929
"devDependencies": {
3030
"@angular/build": "~21.1.5",
3131
"@angular-devkit/build-angular": "~21.1.5",
32-
"@angular-eslint/builder": "~21.2.0",
33-
"@angular-eslint/eslint-plugin": "~21.2.0",
34-
"@angular-eslint/eslint-plugin-template": "~21.2.0",
35-
"@angular-eslint/schematics": "~21.2.0",
36-
"@angular-eslint/template-parser": "~21.2.0",
3732
"@angular/cli": "~21.1.5",
3833
"@angular/compiler-cli": "~21.1.5",
3934
"@types/jasmine": "~5.1.4",
40-
"@typescript-eslint/eslint-plugin": "~8.47.0",
41-
"@typescript-eslint/parser": "~8.47.0",
35+
"angular-eslint": "~21.2.0",
4236
"eslint": "~9.39.1",
43-
"eslint-plugin-import": "^2.32.0",
44-
"eslint-plugin-prefer-arrow": "^1.2.3",
45-
"eslint-plugin-unicorn": "^62.0.0",
4637
"igniteui-cli": "~<%=cliVersion%>",
4738
"jasmine-core": "~5.12.1",
4839
"karma": "~6.4.4",
4940
"karma-chrome-launcher": "~3.2.0",
5041
"karma-coverage": "~2.2.1",
5142
"karma-jasmine": "~5.1.0",
5243
"karma-jasmine-html-reporter": "~2.1.0",
53-
"typescript": "~5.9.3"
44+
"typescript": "~5.9.3",
45+
"typescript-eslint": "~8.47.0"
5446
}
5547
}

packages/igx-templates/igx-ts-legacy/projects/side-nav-auth/files/package.json

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,31 +30,23 @@
3030
"devDependencies": {
3131
"@angular/build": "~21.1.5",
3232
"@angular-devkit/build-angular": "~21.1.5",
33-
"@angular-eslint/builder": "~21.2.0",
34-
"@angular-eslint/eslint-plugin": "~21.2.0",
35-
"@angular-eslint/eslint-plugin-template": "~21.2.0",
36-
"@angular-eslint/schematics": "~21.2.0",
37-
"@angular-eslint/template-parser": "~21.2.0",
3833
"@angular/cli": "~21.1.5",
3934
"@angular/compiler-cli": "~21.1.5",
4035
"@angular/language-service": "~21.1.5",
4136
"@types/facebook-js-sdk": "~3.3.6",
4237
"@types/hammerjs": "~2.0.41",
4338
"@types/jasmine": "~5.1.4",
4439
"@types/jasminewd2": "~2.0.3",
45-
"@typescript-eslint/eslint-plugin": "~8.47.0",
46-
"@typescript-eslint/parser": "~8.47.0",
40+
"angular-eslint": "~21.2.0",
4741
"eslint": "~9.39.1",
48-
"eslint-plugin-import": "^2.32.0",
49-
"eslint-plugin-prefer-arrow": "^1.2.3",
50-
"eslint-plugin-unicorn": "^62.0.0",
5142
"igniteui-cli": "~<%=cliVersion%>",
5243
"jasmine-core": "~5.12.1",
5344
"karma": "~6.4.4",
5445
"karma-chrome-launcher": "~3.2.0",
5546
"karma-coverage": "~2.2.1",
5647
"karma-jasmine": "~5.1.0",
5748
"karma-jasmine-html-reporter": "~2.1.0",
58-
"typescript": "~5.9.3"
49+
"typescript": "~5.9.3",
50+
"typescript-eslint": "~8.47.0"
5951
}
6052
}

packages/igx-templates/igx-ts/projects/_base/files/eslint.config.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
// @ts-check
22
const eslint = require("@eslint/js");
3+
const { defineConfig } = require("eslint/config");
34
const tseslint = require("typescript-eslint");
45
const angular = require("angular-eslint");
56

6-
module.exports = tseslint.config(
7+
module.exports = defineConfig([
78
{
89
files: ["**/*.ts"],
910
extends: [
1011
eslint.configs.recommended,
11-
...tseslint.configs.recommended,
12-
...tseslint.configs.stylistic,
13-
...angular.configs.tsRecommended,
12+
tseslint.configs.recommended,
13+
tseslint.configs.stylistic,
14+
angular.configs.tsRecommended,
1415
],
1516
processor: angular.processInlineTemplates,
1617
rules: {
@@ -38,11 +39,11 @@ module.exports = tseslint.config(
3839
{
3940
files: ["**/*.html"],
4041
extends: [
41-
...angular.configs.templateRecommended,
42+
angular.configs.templateRecommended
4243
],
4344
rules: {
4445
// Relax rules
45-
"@angular-eslint/template/eqeqeq": "off",
46+
"@angular-eslint/template/eqeqeq": "off"
4647
},
4748
}
48-
);
49+
]);

packages/igx-templates/igx-ts/projects/side-nav-auth/files/package.json

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,30 +30,22 @@
3030
"devDependencies": {
3131
"@angular/build": "~21.1.5",
3232
"@angular-devkit/build-angular": "~21.1.5",
33-
"@angular-eslint/builder": "~21.2.0",
34-
"@angular-eslint/eslint-plugin": "~21.2.0",
35-
"@angular-eslint/eslint-plugin-template": "~21.2.0",
36-
"@angular-eslint/schematics": "~21.2.0",
37-
"@angular-eslint/template-parser": "~21.2.0",
3833
"@angular/cli": "~21.1.5",
3934
"@angular/compiler-cli": "~21.1.5",
4035
"@angular/language-service": "~21.1.5",
4136
"@types/facebook-js-sdk": "~3.3.6",
4237
"@types/hammerjs": "~2.0.46",
4338
"@types/jasmine": "~5.1.4",
44-
"@typescript-eslint/eslint-plugin": "~8.47.0",
45-
"@typescript-eslint/parser": "~8.47.0",
39+
"angular-eslint": "~21.2.0",
4640
"eslint": "~9.39.1",
47-
"eslint-plugin-import": "^2.32.0",
48-
"eslint-plugin-prefer-arrow": "^1.2.3",
49-
"eslint-plugin-unicorn": "^62.0.0",
5041
"igniteui-cli": "~<%=cliVersion%>",
5142
"jasmine-core": "~5.12.1",
5243
"karma": "~6.4.4",
5344
"karma-chrome-launcher": "~3.2.0",
5445
"karma-coverage": "~2.2.1",
5546
"karma-jasmine": "~5.1.0",
5647
"karma-jasmine-html-reporter": "~2.1.0",
57-
"typescript": "~5.9.3"
48+
"typescript": "~5.9.3",
49+
"typescript-eslint": "~8.47.0"
5850
}
5951
}

0 commit comments

Comments
 (0)