fix: Add vite.config.ts support to upgrade-packages command#1410
Closed
fix: Add vite.config.ts support to upgrade-packages command#1410
Conversation
Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] fix: Should upgrade cli command to update vite.config? #1388
Note: The discussion in the issue to find the proper solution
fix: Add vite.config.ts support to upgrade-packages command
Aug 20, 2025
Copilot AI
added a commit
that referenced
this pull request
Aug 20, 2025
…ttern fix Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Contributor
|
Closing, because the fix is already in #1408 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1388 - The
ig upgrade-packagescommand now correctly updates trial package references to licensed package references invite.config.tsfiles for React and WebComponents projects.Problem
When using
ig upgrade-packages, the CLI would upgrade package references in TypeScript/TSX files, CSS files, HTML files, and package.json files, but would skipvite.config.tsfiles. This meant that references like:Would not be upgraded to use the licensed package paths:
Solution
Added
vite.config.tsfiles to the logic files collection that gets processed during the upgrade for React and WebComponents projects. The existing regex patterns that handle import statement upgrades also correctly handle the string literal paths in vite.config.ts files.Changes
packages/core/update/Update.ts: Added 6 lines to include vite.config.ts files in the upgrade process for React and WebComponents frameworksspec/unit/update-spec.ts: Added comprehensive tests for both React and WebComponents vite.config.ts upgrade scenarios and updated existing test expectationsTesting
The fix is minimal and surgical, leveraging the existing upgrade infrastructure while extending support to an important configuration file used in modern Vite-based projects.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.google-analytics.comIgnite UI CLI(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.