refactor: remove leftover wrappers AngularTemplate and related tests#1556
Merged
damyanpetev merged 1 commit intomasterfrom Mar 20, 2026
Merged
refactor: remove leftover wrappers AngularTemplate and related tests#1556damyanpetev merged 1 commit intomasterfrom
damyanpetev merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated AngularTemplate wrapper implementation and its associated unit tests, consolidating Angular template behavior around IgniteUIForAngularTemplate from @igniteui/angular-templates.
Changes:
- Deleted the legacy
AngularTemplateclass from the CLI package. - Removed the
AngularTemplatebase unit test suite. - Updated
addcommand unit tests to stop referencingAngularTemplateand useIgniteUIForAngularTemplateinstead.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/unit/base-templates/AngularTemplate-spec.ts | Removes unit tests targeting the deleted legacy AngularTemplate wrapper. |
| spec/unit/add-spec.ts | Drops AngularTemplate usage in tests and switches a remaining instantiation to IgniteUIForAngularTemplate. |
| packages/cli/lib/templates/AngularTemplate.ts | Removes the legacy Angular wrapper template implementation from the CLI package. |
Comments suppressed due to low confidence (1)
spec/unit/add-spec.ts:379
- This test calls
addCmd.addTemplate(...), which returns a Promise, but the call isn’t awaited. Since the spec function isasync, this can make the expectations run beforeaddTemplatecompletes and can lead to flaky behavior (and potentially unhandled async failures). Await the call and consider asserting thatregisterInProject/processTemplatesare not invoked when the module path is invalid, and that the returned value isfalse.
it("Should not add component and should log error if wrong path is passed to module", async () => {
spyOn(Util, "fileExists").and.returnValue(false);
spyOn(Util, "error");
const wrongPath = "myCustomModule/my-custom-module.module.ts";
addCmd.addTemplate("test-file-name", new IgniteUIForAngularTemplate(__dirname), { modulePath: wrongPath });
expect(Util.fileExists).toHaveBeenCalledTimes(1);
expect(Util.error).toHaveBeenCalledTimes(1);
expect(Util.error).toHaveBeenCalledWith(`Wrong module path provided: ${wrongPath}. No components were added!`);
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Hristo313
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1491
Additional information related to this pull request: