Skip to content

Migrate igx-ts templates to Angular signals and inject() function#1586

Draft
Copilot wants to merge 7 commits intomasterfrom
copilot/migrate-to-angular-signals
Draft

Migrate igx-ts templates to Angular signals and inject() function#1586
Copilot wants to merge 7 commits intomasterfrom
copilot/migrate-to-angular-signals

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

  • Explore repository structure and understand the CLI
  • List all available igx-ts templates (45 templates)
  • Create igx-ts project and add all 45 component templates
  • Install dependencies and build the Angular project
  • Fix build errors found during testing:
    • awesome-grid: unwrap viewChild signal in createAbsoluteOverlaySettings() call
    • fintech-grid: fix null safety for groupsRecords optional chain
    • fintech-grid: fix data null assertion in guarded block
  • Verify build succeeds with all 45 templates
  • All 379 existing tests pass (9 pre-existing failures)
  • Lint passes
  • Update CHANGELOG.md with signals/inject migration entry
  • Post test results in PR

End-to-End Template Test Results

Test Setup

  • Created a fresh igx-ts project using ig new TestProject --framework=angular --type=igx-ts --theme=default
  • Added all 45 available component templates using ig add

Template Scaffolding: All 45/45 templates scaffolded successfully ✅

accordion, autocomplete, enhanced-autocomplete, bullet-graph, calendar, carousel, category-chart, chip, combo, date-picker, dialog, dock-manager, dropdown, financial-chart, grid, grid-batch-editing, custom-grid, grid-summaries, grid-multi-column-headers, hierarchical-grid, hierarchical-grid-batch-editing, hierarchical-grid-custom, hierarchical-grid-summaries, input-group, linear-gauge, list, geographic-map, pivot-grid, radial-gauge, select, select-groups, select-in-form, stepper, bottom-nav, tabs, time-picker, tooltip, tree, custom-tree-grid, awesome-grid, crm-grid, fintech-grid, fintech-tree-grid, login, weather-forecast

Angular Build: ✅ Application bundle generation complete (53s)

  • Zero TypeScript errors
  • Zero Angular compiler errors
  • Only pre-existing warnings (Sass deprecations, ESM module warnings from third-party deps)

Existing Test Suite: ✅ All 379 specs pass

  • Same 9 pre-existing failures (unrelated ./output/ directory issues)
  • No new test failures

Bug Fixes Applied During Testing

  1. awesome-grid: Fixed this.grid1this.grid1() as any in createAbsoluteOverlaySettings() — signal was not unwrapped
  2. fintech-grid: Fixed null safety for groupsRecords optional chain and data property access with non-null assertions where values are guarded by if checks

Copilot AI and others added 2 commits March 31, 2026 21:58
…d inject() function

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/f864bfd5-94a9-4116-b42a-29df85870377

Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Coverage Status

coverage: 86.413%. remained the same
when pulling 1040ead on copilot/migrate-to-angular-signals
into 009537d on master.

@damyanpetev damyanpetev force-pushed the copilot/migrate-to-angular-signals branch from 1978764 to 45e91a1 Compare April 2, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants