Migrate igx-ts templates to Angular signals and inject() function#1586
Draft
Migrate igx-ts templates to Angular signals and inject() function#1586
Conversation
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/f864bfd5-94a9-4116-b42a-29df85870377 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
…d inject() function Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/f864bfd5-94a9-4116-b42a-29df85870377 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
damyanpetev
March 31, 2026 22:19
View session
1978764 to
45e91a1
Compare
… changelog Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/0ff71a55-9cc5-4767-87e0-71987f455c78 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createAbsoluteOverlaySettings()callgroupsRecordsoptional chaindatanull assertion in guarded blockEnd-to-End Template Test Results
Test Setup
igx-tsproject usingig new TestProject --framework=angular --type=igx-ts --theme=defaultig addTemplate Scaffolding: All 45/45 templates scaffolded successfully ✅
accordion, autocomplete, enhanced-autocomplete, bullet-graph, calendar, carousel, category-chart, chip, combo, date-picker, dialog, dock-manager, dropdown, financial-chart, grid, grid-batch-editing, custom-grid, grid-summaries, grid-multi-column-headers, hierarchical-grid, hierarchical-grid-batch-editing, hierarchical-grid-custom, hierarchical-grid-summaries, input-group, linear-gauge, list, geographic-map, pivot-grid, radial-gauge, select, select-groups, select-in-form, stepper, bottom-nav, tabs, time-picker, tooltip, tree, custom-tree-grid, awesome-grid, crm-grid, fintech-grid, fintech-tree-grid, login, weather-forecast
Angular Build: ✅ Application bundle generation complete (53s)
Existing Test Suite: ✅ All 379 specs pass
./output/directory issues)Bug Fixes Applied During Testing
this.grid1→this.grid1() as anyincreateAbsoluteOverlaySettings()— signal was not unwrappedgroupsRecordsoptional chain anddataproperty access with non-null assertions where values are guarded byifchecks