Skip to content

Re-apply Web Components Grids fixes#1593

Merged
kdinev merged 2 commits intomasterfrom
dpetev/pick-reverted-tests
Apr 2, 2026
Merged

Re-apply Web Components Grids fixes#1593
kdinev merged 2 commits intomasterfrom
dpetev/pick-reverted-tests

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

@damyanpetev damyanpetev commented Apr 2, 2026

Cherry-pick 7b0d992 from #1562 that got lost merge conflict resolutions somehow.

Edit: Strike that, picking both commits from PR since both are gone from master.

Copilot AI review requested due to automatic review settings April 2, 2026 09:36
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Coverage Status

coverage: 86.413% (+8.8%) from 77.588%
when pulling d9a9967 on dpetev/pick-reverted-tests
into e5a69f0 on master.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/adjusts template-spec checks to ensure template metadata is valid and to detect potential template file collisions, including new coverage for Web Components (igc-ts) templates. This aligns with the intent of PR #1562 to harden template correctness checks.

Changes:

  • Add a new webcomponents-spec.ts to verify Web Components templates have IDs and do not collide internally for igc-ts.
  • Initialize the CLI core App container in template specs (beforeAll) to ensure filesystem-backed utilities work during tests.
  • Improve collision-test assertion messages by switching to withContext(...).toBeTruthy().

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

File Description
spec/templates/webcomponents-spec.ts New spec covering Web Components template IDs and igc-ts collision checks.
spec/templates/react-spec.ts Adds App.initialize() and improves collision assertion context formatting.
spec/templates/jquery-spec.ts Adds App.initialize() and updates ID assertion to use withContext.
spec/templates/angular-spec.ts Adds App.initialize() and improves collision assertion context formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev changed the title test(templates): add igc-ts checks, minor update Re-apply Web Components Grids fixes Apr 2, 2026
@kdinev kdinev merged commit 566305e into master Apr 2, 2026
3 checks passed
@kdinev kdinev deleted the dpetev/pick-reverted-tests branch April 2, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants