Skip to content

feat(igc-ts): update igniteui packages to latest#1597

Merged
damyanpetev merged 4 commits intomasterfrom
dpetev/update-wc-latest
Apr 2, 2026
Merged

feat(igc-ts): update igniteui packages to latest#1597
damyanpetev merged 4 commits intomasterfrom
dpetev/update-wc-latest

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

Re-apply of #1566

Copilot AI review requested due to automatic review settings April 2, 2026 10:33
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 2, 2026

Coverage Status

coverage: 86.413%. remained the same
when pulling a5e4147 on dpetev/update-wc-latest
into 6b98dbd on master.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the igc-ts Web Components CLI templates to newer Ignite UI package versions (v7.x) and upgrades Dock Manager to v2.x, including an updated Dock Manager sample implementation.

Changes:

  • Bumped Ignite UI Web Components template package references from ~6.x to ~7.x across several component templates.
  • Updated the _base_with_home project template dependencies to Ignite UI Web Components 7.x and igniteui-dockmanager 2.x.
  • Refactored the Dock Manager template sample to the v2 API (defineComponents, layout binding).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/cli/templates/webcomponents/igc-ts/tree/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/radial-gauge/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/package.json Updates generated project dependencies to Ignite UI Web Components 7.x and Dock Manager 2.x.
packages/cli/templates/webcomponents/igc-ts/pie-chart/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/linear-progress/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/linear-gauge/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/grid/grid-summaries/index.ts Bumps grid package reference to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/index.ts Bumps grid package reference to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/grid/default/index.ts Bumps grid package reference to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/financial-chart/default/index.ts Bumps template package references to ~7.0.0.
packages/cli/templates/webcomponents/igc-ts/dock-manager/default/index.ts Updates Dock Manager package reference to ^2.1.0.
packages/cli/templates/webcomponents/igc-ts/dock-manager/default/files/src/app/path/filePrefix.ts Refactors Dock Manager sample to v2 API and in-template layout definition.
Comments suppressed due to low confidence (1)

packages/cli/templates/webcomponents/igc-ts/dock-manager/default/files/src/app/path/filePrefix.ts:23

  • The igc-dockmanager element no longer has explicit sizing styles (previously it was included in :host, igc-dockmanager { height: 100%; ... }). With the slotted content using height: calc(100% - 1rem), the dock manager may not fill the available height and can collapse depending on defaults. Consider adding igc-dockmanager { height: 100%; width: 100%; } (or equivalent) to ensure consistent rendering.
  static styles = css`
    :host {
      height: 100%;
      margin: 0px;
      width: calc(100% - 275px);
    }

    .dockManagerContent {
      padding: 0.5rem;
      height: calc(100% - 1rem);
      width: calc(100% - 1rem);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev requested a review from Copilot April 2, 2026 10:44
@damyanpetev damyanpetev requested a review from kdinev April 2, 2026 10:46
@damyanpetev damyanpetev merged commit 009537d into master Apr 2, 2026
5 checks passed
@damyanpetev damyanpetev deleted the dpetev/update-wc-latest branch April 2, 2026 10:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"lit": "^3.3.0",
"typescript": "~5.8.3",
"igniteui-webcomponents": "~6.3.0"
"igniteui-webcomponents": "~7.1.0"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base project pins igniteui-webcomponents to ~7.1.0, while several component templates in this PR install igniteui-webcomponents-* packages at ~7.0.0. That version skew can result in multiple Ignite UI versions being installed simultaneously (and potential runtime/typing mismatches). Consider aligning the versions (either bump the template package versions to match, or pin igniteui-webcomponents to the same minor).

Suggested change
"igniteui-webcomponents": "~7.1.0"
"igniteui-webcomponents": "~7.0.0"

Copilot uses AI. Check for mistakes.
"igniteui-webcomponents-grids": "~6.0.0",
"igniteui-webcomponents-inputs": "~6.0.0",
"igniteui-webcomponents-layouts": "~6.0.0",
"igniteui-dockmanager": "^2.1.0",
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

igniteui-dockmanager is pinned with ^2.1.0, which allows automatic major upgrades (e.g., 3.x) and is inconsistent with the Ignite UI packages here that use ~ pins (e.g., igniteui-webcomponents: ~7.1.0). Consider using a ~2.1.0 pin to reduce the chance of future breaking changes in generated projects.

Suggested change
"igniteui-dockmanager": "^2.1.0",
"igniteui-dockmanager": "~2.1.0",

Copilot uses AI. Check for mistakes.
Comment on lines +14 to +17
"igniteui-webcomponents-core@~7.0.0",
"igniteui-webcomponents-grids@~7.0.0",
"igniteui-webcomponents-inputs@~7.0.0",
"igniteui-webcomponents-layouts@~7.0.0"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template installs several igniteui-webcomponents-* packages, but the generated component imports IgcTreeComponent from igniteui-webcomponents (the umbrella package), and other templates that import from the umbrella package typically don't queue extra subpackages. Unless the Tree sample actually relies on those subpackages, this adds redundant installs and increases the chance of version skew. Consider removing the extra package entries (or switching the sample imports to match the intended subpackage dependencies).

Suggested change
"igniteui-webcomponents-core@~7.0.0",
"igniteui-webcomponents-grids@~7.0.0",
"igniteui-webcomponents-inputs@~7.0.0",
"igniteui-webcomponents-layouts@~7.0.0"
"igniteui-webcomponents@~7.0.0"

Copilot uses AI. Check for mistakes.
this.name = "Dock Manager";
this.description = "Dock Manager with most functionalities and docking options";
this.packages = ["igniteui-dockmanager@~1.14.4"];
this.packages = ["igniteui-dockmanager@^2.1.0"];
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dock-manager template pins igniteui-dockmanager with ^2.1.0, which permits future major upgrades and can break generated projects. Most Ignite UI template packages here use ~ pins; consider switching this to ~2.1.0 for consistency and safer updates.

Suggested change
this.packages = ["igniteui-dockmanager@^2.1.0"];
this.packages = ["igniteui-dockmanager@~2.1.0"];

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants