Skip to content

feat(igc-ts): update web components templates#1609

Open
Hristo313 wants to merge 7 commits intomasterfrom
hhristov/update-wc-templates
Open

feat(igc-ts): update web components templates#1609
Hristo313 wants to merge 7 commits intomasterfrom
hhristov/update-wc-templates

Conversation

@Hristo313
Copy link
Copy Markdown
Contributor

@Hristo313 Hristo313 commented Apr 6, 2026

Updates the igc-ts web components project templates to use Vite as the primary toolchain, replacing @web/dev-server.

Changes Made

  • start:build script: Replaced web-dev-server with vite preview --open in both _base and _base_with_home package.json templates
  • Removed @web/dev-server: Dropped from devDependencies in both package.json templates
  • Removed web-dev-server.config.mjs: Deleted the now-unused web-dev-server configuration file from _base/files/

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Status

coverage: 86.103%. remained the same — hhristov/update-wc-templates into master

@Hristo313
Copy link
Copy Markdown
Contributor Author

@copilot can we use vite for the "start:build" command and remove the web-dev-server ?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

@copilot can we use vite for the "start:build" command and remove the web-dev-server ?

Done in commit f3b08b5. Replaced web-dev-server with vite preview in the start:build script and removed @web/dev-server from devDependencies in both _base and _base_with_home package.json templates.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.google-analytics.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js new --help de_modules/.bin/tsx (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js config --help (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js generate --help (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Hristo313
Copy link
Copy Markdown
Contributor Author

@copilot can we use vite for the "start:build" command and remove the web-dev-server ?

Done in commit f3b08b5. Replaced web-dev-server with vite preview in the start:build script and removed @web/dev-server from devDependencies in both _base and _base_with_home package.json templates.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

We can remove the web-dev-server config file now ? And add --open to the "start:build"

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

@copilot can we use vite for the "start:build" command and remove the web-dev-server ?

Done in commit [f3b08b5](f3b08b57f2c72ca0193a72c34dbfe...

Done in commit a018ec1. Removed web-dev-server.config.mjs and updated start:build to vite preview --open in both templates.

Copilot AI changed the title feat(igx-ts): update web components templates feat(igc-ts): update web components templates Apr 7, 2026
@Hristo313 Hristo313 marked this pull request as ready for review April 7, 2026 14:52
Copilot AI review requested due to automatic review settings April 7, 2026 14:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the igc-ts Web Components CLI templates to standardize on Vite (including preview) instead of @web/dev-server, and adjusts related template tooling (Vitest browser provider + ESLint flat config).

Changes:

  • Replaced web-dev-server usage in start:build scripts with vite preview --open and removed the web-dev-server config file.
  • Updated Vitest browser configuration to use @vitest/browser-playwright’s playwright() provider API.
  • Reworked ESLint template config to a flat eslint.config.js using typescript-eslint + globals.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/cli/templates/webcomponents/igc-ts/projects/side-nav/files/src/app/app.ts Aligns app component export and avoids an unused callback param.
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/web-dev-server.config.mjs Removes unused @web/dev-server configuration.
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/vite.config.ts Updates Vitest browser provider configuration to Playwright helper.
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/package.json Switches start:build to vite preview and updates deps/devDeps.
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.mjs Deletes old ESLint flat config (mjs).
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.js Adds new ESLint flat config using typescript-eslint + globals.
packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/package.json Updates scripts and dependencies to match the Vite-based toolchain.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants