feat(igc-ts): update web components templates#1609
Conversation
|
@copilot can we use vite for the "start:build" command and remove the web-dev-server ? |
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/95ab942c-4353-430b-a3b1-9ae59bb279f9 Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
Done in commit f3b08b5. Replaced Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
We can remove the web-dev-server config file now ? And add --open to the "start:build" |
…view Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/d987f732-ccda-4acf-82e1-83900824d53c Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
Done in commit a018ec1. Removed |
There was a problem hiding this comment.
Pull request overview
This PR updates the igc-ts Web Components CLI templates to standardize on Vite (including preview) instead of @web/dev-server, and adjusts related template tooling (Vitest browser provider + ESLint flat config).
Changes:
- Replaced
web-dev-serverusage instart:buildscripts withvite preview --openand removed theweb-dev-serverconfig file. - Updated Vitest browser configuration to use
@vitest/browser-playwright’splaywright()provider API. - Reworked ESLint template config to a flat
eslint.config.jsusingtypescript-eslint+globals.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/templates/webcomponents/igc-ts/projects/side-nav/files/src/app/app.ts | Aligns app component export and avoids an unused callback param. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/web-dev-server.config.mjs | Removes unused @web/dev-server configuration. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/vite.config.ts | Updates Vitest browser provider configuration to Playwright helper. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/package.json | Switches start:build to vite preview and updates deps/devDeps. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.mjs | Deletes old ESLint flat config (mjs). |
| packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.js | Adds new ESLint flat config using typescript-eslint + globals. |
| packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/package.json | Updates scripts and dependencies to match the Vite-based toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/eslint.config.js
Outdated
Show resolved
Hide resolved
packages/cli/templates/webcomponents/igc-ts/projects/_base_with_home/files/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updates the igc-ts web components project templates to use Vite as the primary toolchain, replacing
@web/dev-server.Changes Made
start:buildscript: Replacedweb-dev-serverwithvite preview --openin both_baseand_base_with_homepackage.json templates@web/dev-server: Dropped fromdevDependenciesin both package.json templatesweb-dev-server.config.mjs: Deleted the now-unused web-dev-server configuration file from_base/files/