Pulling master into vnext for latest deps and lint rules#6448
Merged
Conversation
…d_yarn-8d4971d3be chore(deps): bump the npm_and_yarn group across 1 directory with 3 updates
ChronosSF
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily updates the DocFX documentation sources by standardizing Markdown table formatting (aligned pipe style) across many topics and templates, alongside updating lint tooling/configuration to enforce the new style.
Changes:
- Bumped tooling dependencies (
gulp-autoprefixer,markdownlint-cli) and enabledMD060table style enforcement in.markdownlint.json. - Reformatted numerous Markdown tables to a consistent aligned-pipe layout across component docs.
- Minor structural/content tweaks in a few templates (e.g., heading level adjustments, whitespace cleanup).
Reviewed changes
Copilot reviewed 93 out of 94 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates dev dependency versions for docs tooling. |
| .markdownlint.json | Enables/enforces aligned table pipe style via MD060. |
| en/components/zoomslider-overview.md | Reformats a feature table. |
| en/components/treegrid/tree-grid.md | Reformats “Known Limitations” table. |
| en/components/treegrid/groupby.md | Reformats “Known Limitations” table. |
| en/components/tree.md | Reformats limitations table. |
| en/components/tooltip.md | Reformats predefined positions + limitations tables. |
| en/components/themes/typography.md | Reformats typography scale table alignment row. |
| en/components/themes/sass/roundness.md | Reformats component radius table. |
| en/components/themes/sass/global-themes.md | Reformats Sass mixins/options tables and built-in themes table. |
| en/components/themes/sass/configuration.md | Reformats forwarded Sass variables table. |
| en/components/themes/index.md | Reformats themes list table. |
| en/components/themes/elevations.md | Reformats elevations table. |
| en/components/style-guide.md | Reformats sample table alignment row. |
| en/components/pivotGrid/pivot-grid.md | Reformats “Known Issues and Limitations” table. |
| en/components/paginator.md | Reformats Paging API input/output tables. |
| en/components/overlay-position.md | Reformats multiple strategy default tables. |
| en/components/mask.md | Reformats mask character table. |
| en/components/icon-service.md | Reformats multiple icon mapping tables. |
| en/components/hierarchicalgrid/hierarchical-grid.md | Reformats “Known Limitations” table. |
| en/components/grids_templates/virtualization.md | Removes stray template lines and adjusts an example heading. |
| en/components/grids_templates/validation.md | Removes stray whitespace lines; reformats limitations table. |
| en/components/grids_templates/toolbar.md | Removes stray whitespace lines around conditional blocks. |
| en/components/grids_templates/summaries.md | Removes stray whitespace lines; reformats tables. |
| en/components/grids_templates/search.md | Reformats “Known Limitations” table. |
| en/components/grids_templates/remote-data-operations.md | Adjusts heading level for “Unique Column Values Strategy”. |
| en/components/grids_templates/export-excel.md | Reformats multiple limitations tables. |
| en/components/grids_templates/editing.md | Reformats events/interactions tables. |
| en/components/grids_templates/column-types.md | Reformats timezones and parameter tables. |
| en/components/grids_templates/cell-merging.md | Reformats limitations table. |
| en/components/grid/master-detail.md | Reformats “Known Issues and Limitations” table. |
| en/components/grid/groupby.md | Reformats “Known Limitations” table. |
| en/components/grid/grid.md | Reformats “Known Limitations” table. |
| en/components/grid-lite/theming.md | Reformats theme path table alignment row. |
| en/components/geo-map-type-scatter-density-series.md | Reformats property tables. |
| en/components/geo-map-type-scatter-contour-series.md | Reformats property tables. |
| en/components/geo-map-type-scatter-bubble-series.md | Reformats property table. |
| en/components/geo-map-type-scatter-area-series.md | Reformats property tables. |
| en/components/geo-map-shape-files-reference.md | Reformats shape file extensions table. |
| en/components/geo-map-navigation.md | Reformats navigation properties table. |
| en/components/geo-map-display-imagery-types.md | Reformats imagery tables alignment rows. |
| en/components/geo-map-display-bing-imagery.md | Reformats Bing imagery properties table. |
| en/components/geo-map-display-azure-imagery.md | Reformats Azure imagery properties table. |
| en/components/geo-map-binding-shp-file.md | Reformats shapefile loading + record properties tables. |
| en/components/geo-map-binding-data-model.md | Reformats geographic series data model table. |
| en/components/general/update-guide.md | Reformats theme/type-scale table. |
| en/components/general/open-source-vs-premium.md | Reformats component comparison table. |
| en/components/general/localization.md | Reformats format option tables. |
| en/components/general/how-to/how-to-use-standalone-components.md | Reformats directive collection table. |
| en/components/general/how-to/how-to-perform-crud.md | Reformats CRUD endpoints + events tables. |
| en/components/general/data-analysis.md | Reformats API tables. |
| en/components/general/cli/getting-started-with-cli.md | Reformats templates + commands tables. |
| en/components/general/cli/getting-started-with-angular-schematics.md | Reformats templates table. |
| en/components/general/cli/auth-template.md | Reformats providers table. |
| en/components/general-whats-new-dv.md | Reformats image grid table alignment row. |
| en/components/general-cli-overview.md | Reformats commands table alignment row. |
| en/components/general-breaking-changes-dv.md | Reformats multiple comparison tables. |
| en/components/for-of.md | Reformats “Known Limitations” table. |
| en/components/exporter-pdf.md | Reformats “Known Limitations” table. |
| en/components/exporter-csv.md | Reformats export format mapping table. |
| en/components/expansion-panel.md | Reformats markup parts table. |
| en/components/excel-library-using-worksheets.md | Reformats worksheet filter methods table. |
| en/components/date-time-editor.md | Reformats supported formats table. |
| en/components/date-range-picker.md | Reformats keyboard shortcuts + calendar options tables. |
| en/components/date-picker.md | Reformats keyboard shortcuts table. |
| en/components/chat.md | Reformats inputs/parts/slots/options tables. |
| en/components/charts/types/stacked-chart.md | Reformats API members table. |
| en/components/charts/types/spline-chart.md | Reformats API members table. |
| en/components/charts/types/scatter-chart.md | Reformats API members table. |
| en/components/charts/types/pie-chart.md | Reformats API members table. |
| en/components/charts/types/line-chart.md | Reformats API members table. |
| en/components/charts/types/data-pie-chart.md | Reformats API members table. |
| en/components/charts/types/column-chart.md | Reformats API members table. |
| en/components/charts/types/area-chart.md | Reformats API members table. |
| en/components/charts/features/chart-user-annotations.md | Reformats properties table. |
| en/components/charts/features/chart-tooltips.md | Reformats tooltip type table. |
| en/components/charts/features/chart-navigation.md | Reformats modifier keys table. |
| en/components/charts/features/chart-highlight-filter.md | Reformats API members table. |
| en/components/charts/features/chart-data-selection.md | Reformats placeholder API table. |
| en/components/charts/features/chart-data-legend.md | Reformats column names + customization tables. |
| en/components/charts/features/chart-axis-types.md | Reformats axis compatibility tables. |
| en/components/charts/features/chart-axis-layouts.md | Reformats API references table and comment block. |
| en/components/ai/theming-mcp.md | Reformats tool overview table. |
| en/components/ai/skills.md | Reformats skills and IDE/tool tables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | `Axes` ➔ `NumericYAxis` ➔ `labelSettings.horizontalAlignment` | `YAxisLabelHorizontalAlignment` | | | ||
| | `Axes` ➔ `NumericXAxis` ➔ `labelSettings.verticalAlignment` | `XAxisLabelVerticalAlignment` | | | ||
| | `Axes` ➔ `NumericYAxis` ➔ `labelSettings.visibility` | `YAxisLabelVisibility` | | | ||
| | `Axes` ➔ `NumericXAxis` ➔ `labelSettings.visibility` | `XAxisLabelVisibility` | --> | |
There was a problem hiding this comment.
The HTML comment that wraps the placeholder table is not properly closed: the --> appears mid-line and is followed by a trailing |, which leaves extra characters outside the comment and can break Markdown rendering / linting. Close the HTML comment on its own line (no trailing pipes) and keep the commented table rows fully inside the comment.
Suggested change
| | `Axes` ➔ `NumericXAxis` ➔ `labelSettings.visibility` | `XAxisLabelVisibility` | --> | | |
| | `Axes` ➔ `NumericXAxis` ➔ `labelSettings.visibility` | `XAxisLabelVisibility` | | | |
| --> |
| | Circular Progress | ✅ | ✅ | | ||
| | Color Editor | ❌ | ✅ | | ||
| | Combo | ✅ | ✅ | | ||
| | CVS Exporter | ❌ | ✅ | |
There was a problem hiding this comment.
The comparison table lists "CVS Exporter", which looks like a typo for "CSV Exporter" (the common acronym for comma-separated values). Please correct the component name to avoid confusion.
| | :------------------------------------------------ | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Recursive template nodes | The `igx-tree` does not support recursively creating the igx-tree-nodes via template. [Learn more](https://github.com/IgniteUI/igniteui-angular/wiki/Tree-Specification#assumptions-and-limitations). All of the nodes should be declared manually, meaning if you intend to visualize a very deep hierarchy, this would impact the size of your template file. The tree is intended to be primarily used as a layout / navigational component. If a hierarchical data source with numerous levels of depth and homogenous data needs to be visualized, you could use the [**IgxTreeGrid**](treegrid/tree-grid.md) | | ||
| | Using IgxTreeNodes with old View Engine (pre-Ivy) | There is an issue in Angular's View Engine (pre-Ivy) that prevents the tree from being used when `enableIvy: false` is set in tsconfig.json | | ||
| | Tab navigation in FireFox | Tabbing into the tree via keyboard navigation, when the tree has a scrollbar, will first focus the igx-tree-node element. This is the default behavior in FireFox, however it can be resolved by putting an explicit `tabIndex = -1` on the tree. | |
There was a problem hiding this comment.
Browser name should be spelled "Firefox" (not "FireFox") in this limitation description/table row.
| |[`tilePath`]({environment:dvApiBaseUrl}/products/ignite-ui-angular/api/docs/typescript/latest/classes/igniteui_angular_maps.igxbingmapsmapimagery.html#tilePath)|string|Represents a property that sets the map tile image URI, this is the actual location of the Bing Maps| | ||
| | Property Name | Property Type | Description | | ||
| | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | [`apiKey`]({environment:dvApiBaseUrl}/products/ignite-ui-angular/api/docs/typescript/latest/classes/igniteui_angular_maps.igxbingmapsmapimagery.html#apiKey) | string | Represents the property for setting an API key required for the Bing Maps imagery service. You must obtain this key from the <a href="http://www.bingmapsportal.coms" target="_blank">www.bingmapsportal.com</a> website. | |
There was a problem hiding this comment.
The link for obtaining a Bing Maps API key uses http://www.bingmapsportal.coms in the href, which appears to be an invalid domain (extra trailing 's'). Update the href to the correct Bing Maps Portal URL so the link works.
Comment on lines
+114
to
116
| | Hawaii Standard Time | ‘UTC-10’ | | ||
| | India Standard Time | ‘UTC+4’ | | ||
|
|
There was a problem hiding this comment.
The timezone offset for "India Standard Time" is incorrect here (shown as UTC+4). IST is UTC+5:30 (UTC+05:30). Please update the value to the correct offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Checklist:
preview\beta../relative/path.mdIgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockspending-localizationlabel when the review of the PR is done