feat(aw): updating the workflow with latest aw#6459
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the gh-aw generated workflow used to sync Japanese docs with the latest gh-aw tooling versions and regenerated workflow structure.
Changes:
- Regenerates
.github/workflows/sync-jp-docs.lock.ymlfor gh-aw v0.68.1 (new setup action, updated AWF/Copilot versions, revised job layout/artifacts). - Adds new locked action entries in
.github/aw/actions-lock.jsonfor the updated gh-aw setup action andactions/github-script@v9.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/sync-jp-docs.lock.yml | Regenerated workflow to newer gh-aw version, updating actions, scripts paths, and job structure. |
| .github/aw/actions-lock.json | Updates the action lock manifest to include newer action versions/SHAs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "actions/github-script@v9": { | ||
| "repo": "actions/github-script", | ||
| "version": "v9", | ||
| "sha": "373c709c69115d41ff229c7e5df9f8788daa9553" |
There was a problem hiding this comment.
.github/aw/actions-lock.json pins actions/github-script@v9 to sha 373c709c..., but the workflow uses actions/github-script@3a2844b... in many places. This mismatch can break any validation that relies on actions-lock.json as the source of truth. Align the workflow to the pinned sha or update the lock to match the sha actually used (and keep it consistent across the workflow).
| "sha": "373c709c69115d41ff229c7e5df9f8788daa9553" | |
| "sha": "3a2844b..." |
| GH_AW_INFO_FIREWALL_TYPE: "squid" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 | ||
| uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9 | ||
| with: |
There was a problem hiding this comment.
The workflow uses two different pinned SHAs for actions/github-script v9 (3a2844b... here vs 373c709c... elsewhere). This makes the workflow harder to audit and also conflicts with .github/aw/actions-lock.json which only records one sha for v9. Prefer pinning all actions/github-script steps to a single sha that matches the lock file (or update the lock accordingly).
| - name: Determine automatic lockdown mode for GitHub MCP Server | ||
| id: determine-automatic-lockdown | ||
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 | ||
| uses: actions/github-script@373c709c69115d41ff229c7e5df9f8788daa9553 # v9 | ||
| env: |
There was a problem hiding this comment.
This step pins actions/github-script to sha 373c709c... while the rest of the workflow largely pins 3a2844b.... Please standardize on a single sha for actions/github-script across the workflow (and ensure it matches .github/aw/actions-lock.json).
Closes #
Checklist:
preview\beta../relative/path.mdIgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockspending-localizationlabel when the review of the PR is done