Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

docs(*): Add Material Icons stylesheet note to component docs#6464

Merged
radomirchev merged 10 commits into
vnextfrom
dkalinov/matirial-icons-instructions
Apr 17, 2026
Merged

docs(*): Add Material Icons stylesheet note to component docs#6464
radomirchev merged 10 commits into
vnextfrom
dkalinov/matirial-icons-instructions

Conversation

@dkalinovInfra

@dkalinovInfra dkalinovInfra commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Add a NOTE block to 46 component documentation pages reminding users to include the Google Material Icons stylesheet link in their index.html when using Material Icons with Ignite UI components.

Closes # IgniteUI/igniteui-cli#1618

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

Add a NOTE block to 46 component documentation pages reminding users to
include the Google Material Icons stylesheet link in their index.html
when using Material Icons with Ignite UI components.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a standardized DocFX NOTE callout across many component docs to remind readers to include the Google Material Icons stylesheet when using Material Icons with Ignite UI components.

Changes:

  • Inserted a [!NOTE] admonition with the Material Icons Google Fonts <link> snippet into 46 documentation topics.
  • Placed the reminder near examples that render icons (e.g., igx-icon, icon buttons, grid templates).

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
en/components/action-strip.md Adds Material Icons stylesheet NOTE.
en/components/avatar.md Adds Material Icons stylesheet NOTE.
en/components/badge.md Adds Material Icons stylesheet NOTE.
en/components/banner.md Adds Material Icons stylesheet NOTE.
en/components/button-group.md Adds Material Icons stylesheet NOTE.
en/components/button.md Adds Material Icons stylesheet NOTE.
en/components/card.md Adds Material Icons stylesheet NOTE.
en/components/carousel.md Adds Material Icons stylesheet NOTE.
en/components/chip.md Adds Material Icons stylesheet NOTE.
en/components/circular-progress.md Adds Material Icons stylesheet NOTE.
en/components/combo-templates.md Adds Material Icons stylesheet NOTE.
en/components/date-picker.md Adds Material Icons stylesheet NOTE.
en/components/date-range-picker.md Adds Material Icons stylesheet NOTE.
en/components/dialog.md Adds Material Icons stylesheet NOTE.
en/components/drag-drop.md Adds Material Icons stylesheet NOTE.
en/components/drop-down.md Adds Material Icons stylesheet NOTE.
en/components/grid/grid.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/collapsible-column-groups.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/column-moving.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/excel-style-filtering.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/multi-column-headers.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/row-actions.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/row-adding.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/row-drag.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/row-editing.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/row-pinning.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/search.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/sorting.md Adds Material Icons stylesheet NOTE.
en/components/grids_templates/toolbar.md Adds Material Icons stylesheet NOTE.
en/components/icon-button.md Adds Material Icons stylesheet NOTE.
en/components/icon-service.md Adds Material Icons stylesheet NOTE.
en/components/input-group.md Adds Material Icons stylesheet NOTE.
en/components/linear-progress.md Adds Material Icons stylesheet NOTE.
en/components/list.md Adds Material Icons stylesheet NOTE.
en/components/mask.md Adds Material Icons stylesheet NOTE.
en/components/navbar.md Adds Material Icons stylesheet NOTE.
en/components/navdrawer.md Adds Material Icons stylesheet NOTE.
en/components/select.md Adds Material Icons stylesheet NOTE.
en/components/snackbar.md Adds Material Icons stylesheet NOTE.
en/components/stepper.md Adds Material Icons stylesheet NOTE.
en/components/texthighlight.md Adds Material Icons stylesheet NOTE.
en/components/time-picker.md Adds Material Icons stylesheet NOTE.
en/components/tooltip.md Adds Material Icons stylesheet NOTE.
en/components/transaction-how-to-use.md Adds Material Icons stylesheet NOTE.
en/components/tree.md Adds Material Icons stylesheet NOTE.
en/components/treegrid/load-on-demand.md Adds Material Icons stylesheet NOTE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +70 to +71
>[!NOTE]
> To use Material Icons, add the following link to your `index.html`: `<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">`

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exact NOTE text is now duplicated across many component pages. Consider factoring it into a shared DocFX include/snippet (or linking to a single prerequisite section) to reduce maintenance and localization churn when the guidance needs to change.

Copilot uses AI. Check for mistakes.
Comment thread en/components/tree.md Outdated
Comment thread en/components/input-group.md Outdated
Comment thread en/components/banner.md Outdated
Comment thread en/components/button.md Outdated
Comment thread en/components/button.md Outdated
kdinev and others added 4 commits April 16, 2026 15:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…matting

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-docfx/sessions/fef6f798-f926-40fc-9d39-68620ed0ef79

Co-authored-by: dkalinovInfra <130121354+dkalinovInfra@users.noreply.github.com>
kdinev
kdinev previously approved these changes Apr 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread en/components/icon-service.md Outdated
Comment thread en/components/transaction-how-to-use.md Outdated
Comment on lines +86 to +87
> [!NOTE]
> This component uses Material Icons. Add the following link to your `index.html`: `<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">`

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This NOTE says "This component uses Material Icons", but this topic is a transactions/how-to guide; the icons come from the igx-icon usage in the List example. Consider rewording to "This example uses igx-icon with the default Material Icons family…" (or similar) to avoid implying the transaction service itself depends on Material Icons.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6602bd5. Rewrote the NOTE from "This component uses Material Icons" to "This example uses igx-icon with the default Material Icons family" to accurately reflect that the requirement comes from the igx-icon usage in the list example, not from the transaction service itself.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Comment thread en/components/date-range-picker.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kdinev and others added 2 commits April 17, 2026 14:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…x-icon usage in the example

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-docfx/sessions/b7751b2b-7059-4acf-b59a-6defeb4c7dba

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
Copilot AI requested a review from kdinev April 17, 2026 11:26
Copilot stopped work on behalf of kdinev due to an error April 17, 2026 11:31
@radomirchev radomirchev merged commit 13341d1 into vnext Apr 17, 2026
5 of 6 checks passed
@radomirchev radomirchev deleted the dkalinov/matirial-icons-instructions branch April 17, 2026 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants