Skip to content

fix(grid-finjs): resolve blank iframe and missing code tabs on live-data#6474

Merged
ChronosSF merged 1 commit intovnextfrom
dTsvetkov/fix-finjs-iframe-route
Apr 23, 2026
Merged

fix(grid-finjs): resolve blank iframe and missing code tabs on live-data#6474
ChronosSF merged 1 commit intovnextfrom
dTsvetkov/fix-finjs-iframe-route

Conversation

@dobromirts
Copy link
Copy Markdown
Contributor

Closes # IgniteUI/igniteui-angular-samples#3942

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@ChronosSF ChronosSF merged commit a0573e4 into vnext Apr 23, 2026
5 checks passed
@ChronosSF ChronosSF deleted the dTsvetkov/fix-finjs-iframe-route branch April 23, 2026 07:31
@github-actions github-actions Bot mentioned this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants