refactor: drop updateColumns method after declarative refactor#19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the updateColumns method from the grid component following a refactor to support declarative column updates. Instead of using the imperative updateColumns API, columns can now be updated directly by modifying their properties.
Key Changes:
- Removed the
updateColumnspublic method fromIgcGridLite - Updated test fixture to manipulate column elements directly via DOM queries
- Documented the breaking change in CHANGELOG
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/grid.ts | Removed the updateColumns method from the grid component |
| test/utils/grid-fixture.ts | Replaced method call with direct DOM manipulation of column elements |
| CHANGELOG.md | Documented the breaking change removal of updateColumns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 20170065037Details
💛 - Coveralls |
rkaraivanov
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.