Skip to content

feat(grid): add navigateTo method with optional activation#27

Merged
rkaraivanov merged 1 commit into
masterfrom
dpetev/nativate-method
Jan 14, 2026
Merged

feat(grid): add navigateTo method with optional activation#27
rkaraivanov merged 1 commit into
masterfrom
dpetev/nativate-method

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

Closes #22

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 9, 2026

Pull Request Test Coverage Report for Build 20966291117

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 96.821%

Totals Coverage Status
Change from base Build 20964334188: 0.2%
Covered Lines: 3052
Relevant Lines: 3135

💛 - Coveralls

@damyanpetev damyanpetev requested a review from Copilot January 9, 2026 14:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new navigateTo method to the grid component that allows programmatic navigation to a specific cell with optional activation.

Changes:

  • Added navigateTo public API method with row index, column field, and optional activation parameters
  • Implemented navigation logic using virtualizer's scroll capabilities
  • Added comprehensive test coverage for various navigation scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/components/grid.ts Adds public navigateTo method to the grid component API
src/controllers/navigation.ts Implements navigation logic with scrolling and activation support
test/activation.test.ts Adds extensive test suite for the new navigateTo functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/grid.ts Outdated
@damyanpetev damyanpetev force-pushed the dpetev/nativate-method branch from 39017a0 to afcf7f7 Compare January 9, 2026 14:49
@damyanpetev damyanpetev force-pushed the dpetev/nativate-method branch from afcf7f7 to bab6ab7 Compare January 13, 2026 17:28
@damyanpetev damyanpetev force-pushed the dpetev/nativate-method branch from bab6ab7 to 5218217 Compare January 13, 2026 17:29
@rkaraivanov rkaraivanov merged commit 63faa3d into master Jan 14, 2026
5 checks passed
@rkaraivanov rkaraivanov deleted the dpetev/nativate-method branch January 14, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It would be nice to expose a navigateTo function

4 participants