Fix interactive part of the Circular Progress sample#1020
Merged
Conversation
mddragnev
requested changes
Jan 29, 2026
| if(!progress) { return; } | ||
| this.circularProgress = progress; | ||
| const incrementProgress = () => { | ||
| setCurrentValue(currentValue + 10); |
Member
There was a problem hiding this comment.
In react this is not the correct way to update a state based on its old value. There is a possibility that this introduces bugs depending on react change detection and rendering. You should do it like this:
const incrementProgress = () => {
setCurrentValue((oldValue) => {
const newValue = oldValue + 10;
if (newValue > 100) {
return 100;
}
return newValue;
});
}
Or
const incrementProgress = () => {
setCurrentValue(prev => Math.min(prev + 10, 100));
}
Author
There was a problem hiding this comment.
@mddragnev a very elegant approach indeed! Thanks for catching that! 🙌
added 2 commits
January 30, 2026 14:22
…UI/igniteui-react-examples into mtihova/circular-progress
mddragnev
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #978