Skip to content

Fix interactive part of the Circular Progress sample #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mddragnev merged 4 commits into from
Jan 30, 2026
Merged

Fix interactive part of the Circular Progress sample #1020

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a4f961
fix(circular-progress): Fix interactive part of the sample
Jan 26, 2026
019f6b9
Merge branch 'vnext' into mtihova/circular-progress
mddragnev Jan 29, 2026
dd0dcc5
fix(circular-progress): Edit increment and decrement to handle state …
Jan 30, 2026
e1e7fe5
Merge branch 'mtihova/circular-progress' of https://github.com/Ignite…
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions samples/inputs/circular-progress-indicator/dynamic/src/DynamicCircularProgressStyle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
igc-circular-progress {
--diameter: 100px;
--stroke-thickness: 5px;
}

.sample-content {
width: 300px;
display: flex;
align-items: center;
margin-top: 30px;
}

.circular-progress-container {
margin-right: 50px;
margin-left: 20px;
}

.buttons-container {
display: flex;
gap: 10px;
}
93 changes: 35 additions & 58 deletions samples/inputs/circular-progress-indicator/dynamic/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useEffect, useState } from 'react';
import ReactDOM from 'react-dom/client';
import './index.css';
import { IgrCircularProgress, IgrCircularGradient, IgrIconButton, IgrCircularProgressModule, IgrCircularGradientModule, IgrIconButtonModule, registerIconFromText } from 'igniteui-react';
Expand All @@ -12,70 +12,47 @@ IgrIconButtonModule.register();
const addIconText = '<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M0 0h24v24H0z" fill="none"/><path d="M19 13h-6v6h-2v-6H5v-2h6V5h2v6h6v2z"/></svg>';
const removeIconText = '<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M0 0h24v24H0z" fill="none"/><path d="M19 13H5v-2h14v2z"/></svg>';

export default class DynamicCircularProgress extends React.Component<any, any> {
export default function DynamicCircularProgress() {

public circularProgress: IgrCircularProgress;
public addIcon: IgrIconButton;
public removeIcon: IgrIconButton;
const [currentValue, setCurrentValue] = useState<number>(0);

constructor(props: any) {
super(props);
useEffect(() => {
registerIconFromText("add", addIconText, "material");
registerIconFromText("remove", removeIconText, "material");
}, []);

registerIconFromText(
"add", addIconText, "material"
);
registerIconFromText(
"remove", removeIconText, "material"
);

this.circularProgressRef = this.circularProgressRef.bind(this);
this.onIconClick = this.onIconClick.bind(this);
}

public render(): JSX.Element {
return (
<div style={{width: "300px", display: "flex", alignItems: "center", marginTop: "30px"}}>
<IgrCircularProgress ref={this.circularProgressRef} style={{marginRight: "50px", marginLeft: "20px"}} max={100} value={100}>
<IgrCircularGradient offset="0%" color="#ff9a40">
</IgrCircularGradient>
<IgrCircularGradient offset="50%" color="#1eccd4">
</IgrCircularGradient>
<IgrCircularGradient offset="100%" color="#ff0079">
</IgrCircularGradient>
</IgrCircularProgress>
<div style={{display: "flex", justifyContent: "space evenly", marginTop: "20px"}} onClick={this.onIconClick}>
<IgrIconButton className="removeIcon" name="remove" collection="material">
</IgrIconButton>
<IgrIconButton className="addIcon" name="add" collection="material">
</IgrIconButton>
</div>
</div>
);
}

public circularProgressRef(progress: IgrCircularProgress)
{
if(!progress) { return; }
this.circularProgress = progress;
const incrementProgress = () => {
setCurrentValue(currentValue + 10);

@mddragnev mddragnev Jan 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In react this is not the correct way to update a state based on its old value. There is a possibility that this introduces bugs depending on react change detection and rendering. You should do it like this:

const incrementProgress = () => {
  setCurrentValue((oldValue) => {
     const newValue = oldValue + 10;
     if (newValue > 100) {
       return 100;
     }
      return newValue;
   });
}

Or

const incrementProgress = () => {
    setCurrentValue(prev => Math.min(prev + 10, 100));
}

@MarielaTihova MarielaTihova Jan 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mddragnev a very elegant approach indeed! Thanks for catching that! 🙌

if (currentValue > 100) {
setCurrentValue(100);
}
}

public onIconClick(e: any) {
const target = e.target as HTMLElement;
const iconButton: any = target.closest('igc-icon-button');
if(iconButton.getAttribute("classname") === "removeIcon")
{
if(this.circularProgress.value > 0) {
this.circularProgress.value = this.circularProgress.value - 10;
}
else {
this.circularProgress.value = 0;
}
}
else {
this.circularProgress.value = this.circularProgress.value + 10;
const decrementProgress = () => {
setCurrentValue(currentValue - 10);
if (currentValue < 0) {
setCurrentValue(0);
}

}

return (
<div className="sample-content">
<IgrCircularProgress className="circular-progress-container" max={100} value={currentValue}>
<IgrCircularGradient slot="gradient" offset="0%" color="#ff9a40">
</IgrCircularGradient>
<IgrCircularGradient slot="gradient" offset="50%" color="#1eccd4">
</IgrCircularGradient>
<IgrCircularGradient slot="gradient" offset="100%" color="#ff0079">
</IgrCircularGradient>
</IgrCircularProgress>
<div className="buttons-container">
<IgrIconButton className="removeIcon" name="remove" collection="material" onClick={decrementProgress}>
</IgrIconButton>
<IgrIconButton className="addIcon" name="add" collection="material" onClick={incrementProgress}>
</IgrIconButton>
</div>
</div>
);
}

// rendering above class to the React DOM
Expand Down