Commit 329e2f4
refactor(combo): Use key-bindings controller (#1529)
* refactor(combo): Use key-bindings controller
This commit migrates the combo component to use
the general key-bindings controller from the library.
Aside from unifying the implementation across components
this also improves several behaviours of the combo:
* Keyboard events inside the combo are no longer "swallowed".
* Tab navigation is more natural, i.e. there are no longer 2 tab stops
per combo component.
Updated the combo test suite to accomodate for the
changes.
* fix: Post merge fixes
* feat(combo): update Escape key behavior
* refactor: Some minor code clean-ups
* fix: Arrow Up behavior in both single-select and disable-filtering states
---------
Co-authored-by: MonikaKirkova <monika_kirkova@abv.bg>
Co-authored-by: Bozhidara Pachilova <35433937+ddaribo@users.noreply.github.com>
Co-authored-by: Vasya Kacheshmarova <vasq1989@gmail.com>1 parent 8caf940 commit 329e2f4
3 files changed
Lines changed: 511 additions & 439 deletions
0 commit comments