Skip to content

Commit 5fe70eb

Browse files
authored
chore: Fixed typedoc warnings and internal exports showing in API docs (#2259)
1 parent c903f2b commit 5fe70eb

5 files changed

Lines changed: 26 additions & 8 deletions

File tree

scripts/build-typedoc.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { watch as fsWatch } from 'node:fs';
22
import path from 'node:path';
33
import { fileURLToPath } from 'node:url';
44
import { createServer } from 'vite';
5-
import { Application } from 'typedoc';
5+
import { Application, OptionDefaults } from 'typedoc';
66
import report from './report.mjs';
77

88
const __filename = fileURLToPath(import.meta.url);
@@ -108,6 +108,15 @@ async function main() {
108108
router: 'kind',
109109
excludePrivate: true,
110110
excludeProtected: true,
111+
blockTags: [
112+
...OptionDefaults.blockTags,
113+
'@element',
114+
'@slot',
115+
'@fires',
116+
'@csspart',
117+
'@cssproperty',
118+
'@attr',
119+
],
111120
suppressCommentWarningsInDeclarationFiles: true,
112121
name: 'Ignite UI for Web Components',
113122
readme: 'none',
@@ -139,7 +148,7 @@ async function main() {
139148
await app.generateDocs(project, TYPEDOC.OUTPUT);
140149
await serve();
141150
break;
142-
case 'default':
151+
default:
143152
throw new Error('Unrecognized action argument');
144153
}
145154
}

src/components/combo/combo.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -438,10 +438,6 @@ export default class IgcComboComponent<
438438
/**
439439
* An object that configures the filtering of the combo.
440440
* @attr filtering-options
441-
* @type {FilteringOptions<T>}
442-
* @param filterKey - The key in the data source used when filtering the list of options.
443-
* @param caseSensitive - Determines whether the filtering operation should be case sensitive.
444-
* @param matchDiacritics -If true, the filter distinguishes between accented letters and their base letters.
445441
*/
446442
@property({ type: Object, attribute: 'filtering-options' })
447443
public set filteringOptions(value: Partial<FilteringOptions<T>>) {

src/components/combo/types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,13 @@ export type ComboRenderFunction<T extends object> = RenderItemFunction<
2424
export type ComboValue<T> = T | Values<T>;
2525

2626
/* jsonAPIPlainObject */
27+
/** Filtering options for the combo component. */
2728
export interface FilteringOptions<T extends object> {
29+
/** The key in the data source used when filtering the list of options. */
2830
filterKey: Keys<T> | undefined;
31+
/** Determines whether the filtering operation should be case sensitive. */
2932
caseSensitive?: boolean;
33+
/** If true, the filter distinguishes between accented letters and their base letters */
3034
matchDiacritics?: boolean;
3135
}
3236

src/index.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ export {
8787
// theming configuration
8888
export { configureTheme } from './theming/config.js';
8989
export type { Theme, ThemeVariant } from './theming/types.js';
90-
export { addThemingController as θaddThemingController } from './theming/theming-controller.js';
91-
export { addAdoptedStylesController as θaddAdoptedStylesController } from './components/common/controllers/adopt-styles.js';
9290

9391
// localization objects
9492
export {
@@ -199,3 +197,13 @@ export type {
199197
} from './components/combo/types.js';
200198
export type { IconMeta } from './components/icon/registry/types.js';
201199
export type * from './components/chat/types.js';
200+
201+
// Internal exports for other packages
202+
/** @ignore */
203+
export { addThemingController as θaddThemingController } from './theming/theming-controller.js';
204+
205+
/** @ignore */
206+
export { addAdoptedStylesController as θaddAdoptedStylesController } from './components/common/controllers/adopt-styles.js';
207+
208+
/** @ignore */
209+
export { createAbortHandle as θcreateAbortHandle } from './components/common/abort-handler.js';

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"excludePrivate": true,
4545
"excludeProtected": true,
4646
"excludeExternals": true,
47+
"excludeNotDocumented": true,
4748
"name": "Ignite UI for Web Components",
4849
"readme": "none"
4950
}

0 commit comments

Comments
 (0)