Skip to content

Commit a9ce9e0

Browse files
authored
refactor(splitter): event name align with rest of components (#2161)
1 parent ae6b566 commit a9ce9e0

4 files changed

Lines changed: 25 additions & 10 deletions

File tree

src/components/splitter/splitter.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import IgcTreeComponent from '../tree/tree.js';
2828
import IgcTreeItemComponent from '../tree/tree-item.js';
2929
import type { SplitterOrientation } from '../types.js';
3030
import IgcSplitterComponent, {
31-
type IgcSplitterResizeEventDetail,
31+
type IgcSplitterResizeEventArgs,
3232
} from './splitter.js';
3333

3434
const BAR_PART = 'splitter-bar';
@@ -3074,9 +3074,9 @@ function getPanesSizes(
30743074

30753075
function checkResizeEvents(
30763076
eventSpy: sinon.SinonSpy,
3077-
startArgs?: IgcSplitterResizeEventDetail,
3078-
resizingArgs?: IgcSplitterResizeEventDetail,
3079-
endArgs?: IgcSplitterResizeEventDetail
3077+
startArgs?: IgcSplitterResizeEventArgs,
3078+
resizingArgs?: IgcSplitterResizeEventArgs,
3079+
endArgs?: IgcSplitterResizeEventArgs
30803080
) {
30813081
expect(eventSpy.calledWith('igcResizeStart')).to.be.true;
30823082
expect(eventSpy.calledWith('igcResizing')).to.be.true;

src/components/splitter/splitter.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import { styles } from './themes/splitter.base.css.js';
3535
import { all } from './themes/themes.js';
3636
import type {
3737
IgcSplitterComponentEventMap,
38+
IgcSplitterResizeEventArgs,
3839
IgcSplitterResizeEventDetail,
3940
PanePosition,
4041
PaneResizeSnapshot,
@@ -989,7 +990,11 @@ export default class IgcSplitterComponent extends EventEmitterMixin<
989990
//#endregion
990991
}
991992

992-
export type { IgcSplitterComponentEventMap, IgcSplitterResizeEventDetail };
993+
export type {
994+
IgcSplitterComponentEventMap,
995+
IgcSplitterResizeEventArgs,
996+
IgcSplitterResizeEventDetail,
997+
};
993998

994999
declare global {
9951000
interface HTMLElementTagNameMap {

src/components/splitter/types.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ interface SplitterResizeState {
2525
dragPointerId: number;
2626
}
2727

28-
interface IgcSplitterResizeEventDetail {
28+
interface IgcSplitterResizeEventArgs {
2929
/** The current size of the start panel in pixels */
3030
startPanelSize: number;
3131
/** The current size of the end panel in pixels */
@@ -34,17 +34,24 @@ interface IgcSplitterResizeEventDetail {
3434
delta?: number;
3535
}
3636

37+
/**
38+
* @hidden
39+
* @deprecated use IgcSplitterResizeEventArgs instead
40+
*/
41+
interface IgcSplitterResizeEventDetail extends IgcSplitterResizeEventArgs {}
42+
3743
interface IgcSplitterComponentEventMap {
38-
igcResizeStart: CustomEvent<IgcSplitterResizeEventDetail>;
39-
igcResizing: CustomEvent<IgcSplitterResizeEventDetail>;
40-
igcResizeEnd: CustomEvent<IgcSplitterResizeEventDetail>;
44+
igcResizeStart: CustomEvent<IgcSplitterResizeEventArgs>;
45+
igcResizing: CustomEvent<IgcSplitterResizeEventArgs>;
46+
igcResizeEnd: CustomEvent<IgcSplitterResizeEventArgs>;
4147
}
4248

4349
export type {
4450
PanePosition,
4551
SplitterPaneState,
4652
PaneResizeSnapshot,
4753
SplitterResizeState,
54+
IgcSplitterResizeEventArgs,
4855
IgcSplitterResizeEventDetail,
4956
IgcSplitterComponentEventMap,
5057
};

src/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,10 @@ export type {
176176
export type { PopoverPlacement } from './components/popover/popover.js';
177177
export type { IgcRadioChangeEventArgs } from './components/radio/radio.js';
178178
export type { IgcRangeSliderValueEventArgs } from './components/slider/range-slider.js';
179-
export type { IgcSplitterResizeEventDetail } from './components/splitter/splitter.js';
179+
export type {
180+
IgcSplitterResizeEventArgs,
181+
IgcSplitterResizeEventDetail,
182+
} from './components/splitter/splitter.js';
180183
export type {
181184
IgcActiveStepChangingEventArgs,
182185
IgcActiveStepChangedEventArgs,

0 commit comments

Comments
 (0)