refactor: partNameMap as a Lit directive#1673
Merged
damyanpetev merged 11 commits intomasterfrom May 29, 2025
Merged
Conversation
…niteUI/igniteui-webcomponents into rkaraivanov/partMap-directive
Simplified some of the logic in the `update` method of the directive. Fixed some instances where static parts were still present.
damyanpetev
reviewed
May 29, 2025
Comment on lines
+132
to
+133
| aria-selected=${this.selected} | ||
| aria-disabled=${this.disabled} |
Member
There was a problem hiding this comment.
Side note: We should probably set pattern for bool attrs. Wouldn't these be better off with the ? prefix to skip DOM false values? Applies across the board really.
Member
Author
There was a problem hiding this comment.
Not really because aria-selected and the backing property are typed as string | null, so Lit kind of complains about the ? bindings there.
I do agree we should come with some mechanism that is not the verbose ifDefined(..blah blah) juggle that we currently do at some parts of the codebase.
damyanpetev
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.