-
Notifications
You must be signed in to change notification settings - Fork 10
refactor: partNameMap as a Lit directive #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eab0438
2f0f7c8
8acc033
42d4d0b
3a1f69c
ec8ecc6
b54df46
64dc8c1
95a5ac3
0e8e603
eeaf81f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,9 +128,9 @@ export default class IgcChipComponent extends EventEmitterMixin< | |
| return html` | ||
| <button | ||
| part="base" | ||
| .disabled="${this.disabled}" | ||
| aria-selected="${this.selected ? 'true' : 'false'}" | ||
| aria-disabled="${this.disabled ? 'true' : 'false'}" | ||
| .disabled=${this.disabled} | ||
| aria-selected=${this.selected} | ||
| aria-disabled=${this.disabled} | ||
|
Comment on lines
+132
to
+133
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note: We should probably set pattern for bool attrs. Wouldn't these be better off with the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really because aria-selected and the backing property are typed as |
||
| @click=${this.handleSelect} | ||
| > | ||
| <span | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.