refactor: Keyboard focus ring controller#1684
Merged
damyanpetev merged 11 commits intomasterfrom Jun 5, 2025
Merged
Conversation
… into rkaraivanov/focus-ring-refactor
damyanpetev
reviewed
May 30, 2025
damyanpetev
approved these changes
Jun 5, 2025
Comment on lines
+330
to
+336
| this.addEventListener('pointerdown', () => { | ||
| this._hasInnerFocus = false; | ||
| }); | ||
|
|
||
| this.addEventListener('keyup', () => { | ||
| this._hasInnerFocus = true; | ||
| }); |
Member
There was a problem hiding this comment.
Shouldn't these be replaced with just this._hasInnerFocus = true; on the focusin handler?
Member
There was a problem hiding this comment.
Okay, I get that's the current behavior replicating what the focus ring did, but it doesn't make sense.
See https://igniteui.github.io/igniteui-webcomponents/?path=/story/carousel--inputs-template&args=interval:3000
Where focusing an input and moving the pointer away starts changing slides, which I don't think is nice and we should consider updating that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.