refactor: Simplify iterNodes implementation#1689
Merged
damyanpetev merged 6 commits intomasterfrom May 29, 2025
Merged
Conversation
Moved the filter logic from the JS loop into the native TreeWalker implementation. Aside from a potential performance boost, the code is easier to grok. Dropped support for digging into open shadow roots which was a workaround for igc-radios created inside another ShadowDOM boundry. Radios will now try to resolve their siblings based on their rootNode scope instead of the main document root.
damyanpetev
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the filter logic from the JS loop into the
native TreeWalker implementation. Aside from a
potential performance boost, the code is easier
to grok.
Dropped support for digging into open shadow roots which was a workaround for igc-radios created inside another ShadowDOM boundry. Radios will now try to
resolve their siblings based on their rootNode scope instead of the main document root.