fix(Calendar): Add tag for blazor gen as indirect render.#1701
Merged
rkaraivanov merged 9 commits intomasterfrom Jun 5, 2025
Merged
fix(Calendar): Add tag for blazor gen as indirect render.#1701rkaraivanov merged 9 commits intomasterfrom
rkaraivanov merged 9 commits intomasterfrom
Conversation
damyanpetev
reviewed
May 27, 2025
| * @csspart selected - Indicates selected state. Applies to date, month and year elements of the calendar. | ||
| * @csspart current - Indicates current state. Applies to date, month and year elements of the calendar. | ||
| */ | ||
| @blazorIndirectRender |
Member
There was a problem hiding this comment.
This sould also work with the comment tag, no? Like /* blazorIndirectRender */?
Contributor
Author
There was a problem hiding this comment.
Yes. But it would appear in the comments for the prop. And since we've already defined the decorator and use it for other props might as well use it here as well.
Member
There was a problem hiding this comment.
It shouldn't :) There's a diff with /* not a doc comment */ and /** doc comment */ + those can be mixed like we do in Angular (see action strip for example).
PS: I'm going to be deleting all/most of those decorators since they have runtime component (not good), which is why I advice to avoid them in new changes
damyanpetev
previously approved these changes
May 29, 2025
damyanpetev
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this