Skip to content

fix(textarea): remove height override and fix label line-height #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkaraivanov merged 7 commits into from
Jun 5, 2025
Merged

fix(textarea): remove height override and fix label line-height #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e9b4ca2
fix(textarea): remove height override
desig9stein May 29, 2025
ec8224a
Merge branch 'master' into mpopov/fix/input-group/indigo-textarea-height
desig9stein May 29, 2025
06946e2
fix(textarea): remove unnecessary top 1px since it make difference in…
desig9stein May 29, 2025
3c74c64
fix(textarea): fix label height in indigo theme
desig9stein May 29, 2025
3cbef3a
fix(textarea): make sure line height is the same for input and textar…
desig9stein Jun 2, 2025
8f4f0e1
Merge branch 'master' into mpopov/fix/input-group/indigo-textarea-height
rkaraivanov Jun 5, 2025
14e8ad5
Merge branch 'master' into mpopov/fix/input-group/indigo-textarea-height
rkaraivanov Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/input/themes/shared/input.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,13 @@ $focused-height: calc(var-get($theme, 'size') - #{($focused-border-width * 2)});
}

[part='label'] {
@include type-style('subtitle-2');
@include type-style('subtitle-2') {
--ig-subtitle-2-line-height: #{rem(16px)};

margin-block: 0 rem(5px);
};

color: var-get($theme, 'idle-secondary-color');
margin-block-end: rem(5px);
}

[part^='container'] {
Expand Down
1 change: 0 additions & 1 deletion src/components/input/themes/shared/input.material.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ input:placeholder-shown + [part='notch'] [part='label'],
transform 150ms cubic-bezier(0.4, 0, 0.2, 1),
color 150ms cubic-bezier(0.4, 0, 0.2, 1),
font-size 150ms cubic-bezier(0.4, 0, 0.2, 1);
line-height: normal;
text-overflow: ellipsis;
overflow: hidden;
will-change: font-size, color, transform;
Expand Down
1 change: 0 additions & 1 deletion src/components/textarea/themes/shared/textarea.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ $theme: $bootstrap;
position: static;
display: block;
padding: 0;
line-height: rem(24px);
transform: translateY(0);
transform-origin: top left;
margin-block: 0 rem(4px);
Expand Down
12 changes: 8 additions & 4 deletions src/components/textarea/themes/shared/textarea.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,19 @@ $theme: $fluent;
}

[part~='label'] {
@include type-style('subtitle-2') {
--ig-subtitle-2-line-height: #{rem(16px)};

margin-block: 0 rem(5px);
};

display: block;
font-size: rem(14px);
font-weight: 600;
position: static;
transform: translateY(0);
transform-origin: top left;
margin-top: 0;
height: auto;
margin-block-end: rem(5px);


}

:host([invalid]) {
Expand Down
2 changes: 0 additions & 2 deletions src/components/textarea/themes/shared/textarea.indigo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ $theme: $indigo;
transition: background .25s $out-cubic;
overflow: hidden;
padding-inline-start: 0;
height: calc(100% - #{rem(2px)});
top: rem(1px);

&::after {
content: '';
Expand Down
9 changes: 6 additions & 3 deletions src/components/textarea/themes/shared/textarea.material.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,22 @@ textarea {
}

%label-filled {
@include type-style('caption');

transform: translateY(0);
inset-block-start: calc(#{$input-top-padding} / 4);
font-size: rem(12px);
}

%label-outlined-filled {
@include type-style('caption') {
margin-block-end: auto;
};

display: inline-block;
position: relative;
inset-block: 0;
transform: translateY(-50%);
margin-block-end: auto;
padding-inline-end: 0;
font-size: rem(12px);
}

:host(:not([outlined])) {
Expand Down
4 changes: 1 addition & 3 deletions src/components/textarea/themes/textarea.base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ $base-scale-size: (

[part~='label'] {
@include ellipsis();

line-height: normal;
}
}

Expand Down Expand Up @@ -69,7 +67,7 @@ textarea {

&:not([type='*']) {
/* resets typography styles */
line-height: normal;
line-height: normal;
}
}

Expand Down