Closed
Conversation
simeonoff
reviewed
Jun 26, 2025
Comment on lines
+8
to
+10
| igc-dialog[open]::part(base) { | ||
| box-shadow: var(--ig-elevation-7); | ||
| } |
Collaborator
There was a problem hiding this comment.
Um, shouldn't this be read from the schemas instead of being hard coded?
Contributor
Author
There was a problem hiding this comment.
there are no datepicker elevations in the schemas
Comment on lines
+5
to
+8
| $material: digest-schema($dark-material-calendar); | ||
| $bootstrap: digest-schema($dark-bootstrap-calendar); | ||
| $fluent: digest-schema($dark-fluent-calendar); | ||
| $indigo: digest-schema($dark-indigo-calendar); |
Collaborator
There was a problem hiding this comment.
I believe the reason why we were merging the themes here is so that CSS variables are available to style the date picker component from the outside as a single unit. We need to verify if we're not introducing breaking changes by doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1718, #1719