-
Notifications
You must be signed in to change notification settings - Fork 10
fix(calendar): reflect the orientation attr. #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8f1abe7
fix(calendar): reflect the orientation attr the same way as the heade…
desig9stein 6c7ae4e
fix(calendar): update orientation styling, add new part, and remove i…
desig9stein 7543134
fix(calendar): revert the reflected attr
desig9stein f3988cf
test(calendar): attempt to fix the test
desig9stein f87cdab
fix(calendar): make the rest of the themes to use the new selector
desig9stein b467b5d
Merge branch 'master' into mpopov/calendar-orientation-attr
desig9stein 94ed79d
test(calendar): remove unnecessary display style assertion in orienta…
desig9stein 34a5935
test(calendar): simplify orientation test by checking for the existen…
desig9stein 7349508
test(calendar): refine vertical orientation test to validate part inc…
desig9stein e9105ac
fix(calendar): rename export part to `content-vertical`
desig9stein 1e09896
fix(calendar): update render logic for orientation parts and refine t…
desig9stein 39c84bd
Merge branch 'master' into mpopov/calendar-orientation-attr
desig9stein 4e210c9
Merge branch 'master' into mpopov/calendar-orientation-attr
simeonoff 76d5494
fix(calendar): update part selectors to support multiple values
desig9stein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you can adjust the
getCalendarDOMhelper function to query the content part with the right selector instead of outright removing the check.This is the current version of the calendar DOM content getter.