refactor(rating): Improved code quality and architecture#2171
Merged
rkaraivanov merged 3 commits intomasterfrom Apr 1, 2026
Merged
refactor(rating): Improved code quality and architecture#2171rkaraivanov merged 3 commits intomasterfrom
rkaraivanov merged 3 commits intomasterfrom
Conversation
- Replaced `guard` directive with propery `updated` lifecycle method to handle the projected symbols update. - Use the internal slot controller for managing the projected symbols. - Replaced the generator-based rendering with a more efficient `repeat` + `range` DOM diffing when `max` changes. - The component now follows the project code style and architecture guidelines. - Improved JSDoc description, added slot entries and annotated example usage.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the igc-rating web component to better align with the project’s Lit component architecture (slot controller usage, lifecycle handling) while improving rendering efficiency and documentation.
Changes:
- Replaced directive-based projected symbol handling with a slot controller +
updated()lifecycle hook. - Switched default symbol rendering from a generator approach to
repeat(range(...))for better DOM diffing onmaxchanges. - Expanded/clarified JSDoc, including slot documentation and examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
guarddirective with properyupdatedlifecycle method to handle the projected symbols update.repeat+rangeDOM diffing whenmaxchanges.Type of Change
Checklist