Fix for Useless assignment to local variable#2172
Merged
rkaraivanov merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, unused local-variable assignments should either be removed or the variable should be used meaningfully. Here, the test first uses
barSizefor the horizontal orientation and then reassignsbarSizefor the vertical orientation but never uses the second value. To fix this without changing existing functionality, remove the unnecessary assignment but still keep any side effect if needed (in this case, there is no side effect we rely on, so simply dropping the assignment is safe).Concretely, in
src/components/splitter/splitter.spec.ts, at the block starting around line 880 wheresplitter.orientation = 'vertical';is set, replace the linebarSize = bar.getBoundingClientRect().height;with just a call tobar.getBoundingClientRect().height;or remove the line entirely. Since the return value is not needed, the simplest and cleanest fix is to delete the line. No additional imports, methods, or definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.