Skip to content

Add additional blazor tags for button, highlight and splitter #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkaraivanov merged 2 commits into from
Jun 5, 2026
Merged

Add additional blazor tags for button, highlight and splitter #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a547aaf
Add additional blazor tags for button, highlight and splitter
mddragnev Jun 4, 2026
d3e158f
chore: add blazorSuppress comment in IgcChatComponent
mddragnev Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/button/button-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ export abstract class IgcButtonBaseComponent extends EventEmitterMixin<
}

/* blazorCSSuppress */
/* alternateType: object */
Comment on lines 159 to +160

@damyanpetev damyanpetev Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mddragnev If this is already CS-suppressed, what caused the need for alt object?

@mddragnev mddragnev Jun 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blazorCSSuppress is not entirely suppressing the member but the api analyzer generates it and marks it as BlazorSuppressWidgetMember then the blazor translator skip it. I guess that it has no use now when we dont have our react components using the translator. If you insist I can change that to blazorSuppress and remove the alternateType

@damyanpetev damyanpetev Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blazorSuppress it then (aka full hide)

/**
* The target element for the invoker command. Resolved from the `commandfor` ID.
*/
Expand All @@ -165,6 +166,7 @@ export abstract class IgcButtonBaseComponent extends EventEmitterMixin<
}

/* blazorCSSuppress */
/* alternateType: object */
public set commandForElement(value: Element | null) {
this._commandForElement = value;
this.requestUpdate();
Expand Down
1 change: 1 addition & 0 deletions src/components/chat/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ export default class IgcChatComponent extends EventEmitterMixin<
return this._state.options;
}

/* blazorSuppress */
/**
* The resource strings of the chat.
*/
Expand Down
5 changes: 3 additions & 2 deletions src/components/highlight/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ import type IgcHighlightComponent from './highlight.js';

type Match = { node: Node; indices: [start: number, end: number] };

/* jsonAPIPlainObject */
/**
* Options for controlling navigation behavior when moving the active highlight.
*/
export type HighlightNavigation = {
export interface HighlightNavigation {
/** If true, prevents the component from scrolling the new active match into view. */
preventScroll?: boolean;
};
}

function* matchText(
nodes: IterableIterator<Node>,
Expand Down
1 change: 1 addition & 0 deletions src/components/splitter/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface SplitterResizeState {
dragPointerId: number;
}

/* jsonAPIPlainObject */
interface IgcSplitterResizeEventArgs {
/** The current size of the start panel in pixels */
startPanelSize: number;
Expand Down
Loading