Skip to content

refactor(nav-drawer): use shared theming size tokens #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkaraivanov merged 2 commits into from
Jul 6, 2026
+15 −31
Merged

refactor(nav-drawer): use shared theming size tokens #2285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bf672
refactor(nav-drawer): use shared theming size tokens
simeonoff Jul 3, 2026
d0a3cf6
deps(theming): bump to latest version
simeonoff Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"husky": "^9.1.7",
"ig-typedoc-theme": "^7.0.1",
"igniteui-i18n-resources": "^1.0.5",
"igniteui-theming": "^27.3.0",
"igniteui-theming": "^27.4.0",
"keep-a-changelog": "^3.0.5",
"lint-staged": "^17.0.8",
"lit-analyzer": "^2.0.3",
Expand Down
10 changes: 6 additions & 4 deletions src/components/nav-drawer/themes/container.base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
@use 'styles/common/component';
@use 'styles/utilities' as *;
@use './light/themes' as *;

$theme: $base;

:host {
--menu-full-width: #{rem(240px)};
--menu-height: 50vh;
--transition-function: cubic-bezier(0.445, 0.05, 0.55, 0.95);
--transition-duration: 0.35s;
Expand All @@ -24,7 +26,7 @@
}

[part='mini'] {
width: var(--menu-mini-width);
width: var-get($theme, 'size--mini');
transition-behavior: allow-discrete;
Comment thread
simeonoff marked this conversation as resolved.
transition-duration: var(--transition-duration);
transition-timing-function: var(--transition-function);
Expand All @@ -37,7 +39,7 @@

[part='base'] {
box-sizing: border-box;
width: var(--menu-full-width);
width: var-get($theme, 'size');
padding: unset;
Comment thread
simeonoff marked this conversation as resolved.
transition-behavior: allow-discrete;
transition-duration: var(--transition-duration);
Expand Down Expand Up @@ -279,7 +281,7 @@

:host(:not([open])[position='relative']) {
[part='base'] {
margin-inline-start: calc(var(--menu-full-width) * -1);
margin-inline-start: calc(#{var-get($theme, 'size')} * -1);
border-color: transparent;
Comment thread
simeonoff marked this conversation as resolved.
overflow: hidden;
}
Expand Down
5 changes: 2 additions & 3 deletions src/components/nav-drawer/themes/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { styles as materialLight } from './light/container/nav-drawer.material.c
import { styles as sharedLight } from './light/container/nav-drawer.shared.css.js';
// Shared Styles
import { styles as bootstrap } from './shared/container/nav-drawer.bootstrap.css.js';
import { styles as fluent } from './shared/container/nav-drawer.fluent.css.js';
import { styles as indigo } from './shared/container/nav-drawer.indigo.css.js';
import { styles as material } from './shared/container/nav-drawer.material.css.js';

Expand All @@ -30,7 +29,7 @@ const light = {
${material} ${materialLight}
`,
fluent: css`
${fluent} ${fluentLight}
${fluentLight}
`,
indigo: css`
${indigo} ${indigoLight}
Expand All @@ -48,7 +47,7 @@ const dark = {
${material} ${materialDark}
`,
fluent: css`
${fluent} ${fluentDark}
${fluentDark}
`,
indigo: css`
${indigo} ${indigoDark}
Expand Down
4 changes: 0 additions & 4 deletions src/components/nav-drawer/themes/shared/container/nav-drawer.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
@use 'styles/utilities' as *;

:host {
--menu-mini-width: #{rem(88px)};
}

[part='mini'],
[part='main'] {
padding: pad(rem(16px));
Expand Down
8 changes: 0 additions & 8 deletions src/components/nav-drawer/themes/shared/container/nav-drawer.fluent.scss
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions src/components/nav-drawer/themes/shared/container/nav-drawer.indigo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
$theme: $indigo;

:host {
--menu-mini-width: #{rem(48px)};

[part='base']::backdrop {
background: var-get($overlay-indigo, 'background-color');
}

[part='mini'], [part="main"] {
[part='mini'],
[part='main'] {
padding: pad(rem(8px));
}
}
4 changes: 0 additions & 4 deletions src/components/nav-drawer/themes/shared/container/nav-drawer.material.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
@use 'styles/utilities' as *;

:host {
--menu-mini-width: #{rem(56px)};
}

[part='mini'],
[part='main'] {
padding: pad(rem(8px));
Expand Down