Update cell editing topic with v19 info for react#1501
Merged
Conversation
MayaKirova
requested changes
Jun 9, 2025
| ```typescript | ||
| function keydownHandler(event) { | ||
| const key = event.keyCode; | ||
| function keydownHandler(args: IgrGridKeydownEventArgs) { |
Contributor
There was a problem hiding this comment.
I don't think this should be the grid's keydown event, since it is fired only if the key combination is supported in the grid (an existing key combination for edit, navigation etc.) . Hence it would not fire for number keys or alphabet keys.
This probably needs to be the generic keydown event and the snippets and text around the sample should be updated accordingly.
MayaKirova
requested changes
Jun 10, 2025
| selected={e.dataContext.cell.value == i[field]} | ||
| selected={e.cell.value == i[field]} | ||
| value={i[field]} | ||
| key={key + "_" + index} |
Contributor
There was a problem hiding this comment.
We can omit the key, since it's no longer necessary.
| <!-- ComponentStart: HierarchicalGrid --> | ||
| ```tsx | ||
| public handleCellEdit(sender: IgrHierarchicalGrid, event: IgrGridEditEventArgs): void { | ||
| public handleCellEdit(event: IgrGridEditEventArgs): void { |
Contributor
There was a problem hiding this comment.
The sample and snippet for the hierarchical grid don't seem to match since they show different data.
MayaKirova
approved these changes
Jun 10, 2025
MayaKirova
added
status: verified ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.