Skip to content

Update filtering topic for React 19#1514

Merged
dkamburov merged 2 commits into
vnextfrom
mtihova/filtering-topic-update
May 22, 2025
Merged

Update filtering topic for React 19#1514
dkamburov merged 2 commits into
vnextfrom
mtihova/filtering-topic-update

Conversation

@MarielaTihova
Copy link
Copy Markdown
Contributor

No description provided.

@mddragnev mddragnev self-requested a review May 9, 2025 11:40
Copy link
Copy Markdown
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of snippets where this keyword is used. We should show snippets with functional components code. Could you remove those?

Also, there is a typo here To enable the [Advanced filtering](http://localhost:3000/components/grids/grid/advanced-filtering.html) however, you need to set the [allowAdvancedFiltering](https://staging.infragistics.com/products/ignite-ui-react/api/docs/typescript/latest/classes/igniteui_react_grids.igrgridbasedirective.html#allowAdvancedFiltering) input property to true.7 at the end there is a number 7.

Also, could you refactor the Initial filtered state snippet so that it uses functional components style. Please, make sure that there is no type casting. It could look as clean as:

  const filteringExpressionTree: IgrFilteringExpressionsTree = {
    operator: FilteringLogic.And,
    filteringOperands: [
      {
        fieldName: "ProductID",
        conditionName: "equals",
        ignoreCase: true,
        searchVal: 1,
      },
    ],
  };

@dkamburov dkamburov merged commit f23193c into vnext May 22, 2025
11 checks passed
@dkamburov dkamburov deleted the mtihova/filtering-topic-update branch May 22, 2025 13:57
@randriova randriova added the status: localized indicates that localization is complete label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: localized indicates that localization is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants