Skip to content

fix(docs): updated multi column headers docs to 19#1518

Merged
dkamburov merged 4 commits into
vnextfrom
ttonev/multi-column-headers
May 22, 2025
Merged

fix(docs): updated multi column headers docs to 19#1518
dkamburov merged 4 commits into
vnextfrom
ttonev/multi-column-headers

Conversation

@tishko0
Copy link
Copy Markdown
Contributor

@tishko0 tishko0 commented May 7, 2025

No description provided.

@mddragnev mddragnev self-requested a review May 14, 2025 10:49
@mddragnev mddragnev changed the title fix(docs): updated docs to 19 fix(docs): updated multi column headers docs to 19 May 14, 2025
Copy link
Copy Markdown
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section about Multi-Column Header Template has some snippets that have wrong signature for the template. Also, could you please create the functions as lambdas? Also, please test them.

@mddragnev
Copy link
Copy Markdown
Member

Please update the hgrid and treegrid topics as well

@tishko0 tishko0 requested a review from mddragnev May 15, 2025 12:28
Copy link
Copy Markdown
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GridColumnDataType is no longer available as an enum so you cannot set it like this on the dataType.
Also, there are some this keywoard in the snippets for React. Remove them too, please.

@dkamburov dkamburov merged commit 5da33b4 into vnext May 22, 2025
11 checks passed
@dkamburov dkamburov deleted the ttonev/multi-column-headers branch May 22, 2025 14:02
@randriova randriova added the status: localized indicates that localization is complete label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: localized indicates that localization is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants