fix(react): update editing snippets to 19#1520
Merged
Merged
Conversation
mddragnev
requested changes
May 8, 2025
| ```tsx | ||
| function onSorting(grid: {ComponentName}, event: IgrSortingEventArgs) { | ||
| function onSorting(args: IgrSortingEventArgs) { | ||
| const grid = args.target as IgrGrid; |
Member
There was a problem hiding this comment.
Casting here as IgrGrid breaks the generation of the snippet for Hgrid and Treegrid.
Contributor
Author
There was a problem hiding this comment.
casted as component selector to so it will change to the relevant component based on topic now
mddragnev
changed the title
mddragnev
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.