update data label formating to work for axis annotations also#825
Open
IGvaleries wants to merge 130 commits into25.1from
Open
update data label formating to work for axis annotations also#825IGvaleries wants to merge 130 commits into25.1from
IGvaleries wants to merge 130 commits into25.1from
Conversation
…i-xplat-examples into toolbar-testing
…i-xplat-examples into toolbar-testing
…i-xplat-examples into toolbar-testing
…i-xplat-examples into toolbar-testing
…tform-specific files Agent-Logs-Url: https://github.com/IgniteUI/igniteui-xplat-examples/sessions/37b2777c-b4ca-4010-aa88-b0cbd8126a84 Co-authored-by: gmurray81 <4264873+gmurray81@users.noreply.github.com>
Remove Json.NET types from GTK handlers and split Desktop.cs into pla…
…i-xplat-examples into toolbar-testing
…i-xplat-examples into toolbar-testing
The Swift handler was casting args.item to NSDictionary, but iOS passes the data item as the internal generic DictionaryDataItem<String?, Any?> (the Swift analog of the C# DictionaryDataItem<string, object> used for composite-data rows). The as? NSDictionary cast silently failed, so the label never got reformatted and the test assertion for "A-V-20" / "B-V-40" etc. couldn't find its callouts. Cast to DictionaryDataItem\$2<String?, Any?> directly and subscript it, and emit the Double value as an Int when it is whole (so "20" not "20.0" to match the Desktop handler's "label + "-V-" + value" format). Resolves CategoryChartCalloutLayerCanUpdateAutoCalloutLabelsInCalloutUpdatingEvent on iOS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Swift handler was casting JsonDictionaryValue.value straight to String for the Thickness field, then parsing that string with Double.init. iOS's JSON parser delivers numeric fields as Double, not String, so the cast failed and the test's ShapeThickness=3 override was never applied — the shape kept its default 1.5. Accept either the native Double value or the stringified form as a fallback (matching how JSON.NET on WPF returns "3"/"NaN" for Value<string>()). Resolves DataChartSliceAnnotationsStylingCanStyleSingleSliceOnlyUsingStylingEvents on iOS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…i-xplat-examples into toolbar-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.