Skip to content

Commit 73c227f

Browse files
committed
refactor(tests): improve formatting and organization in ProductServiceTest and UserServiceTest
Updated test classes to enhance readability by adjusting formatting and ensuring consistent spacing in method definitions and assertions.
1 parent 7ee962d commit 73c227f

2 files changed

Lines changed: 6 additions & 45 deletions

File tree

src/test/java/com/example/store/product/application/ProductServiceTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
import java.nio.charset.StandardCharsets;
2020
import java.util.List;
2121

22-
import static org.junit.jupiter.api.Assertions.*;
22+
import static org.junit.jupiter.api.Assertions.assertEquals;
23+
import static org.junit.jupiter.api.Assertions.assertNotNull;
2324

2425
@ExtendWith(MockitoExtension.class)
25-
public class ProductServiceTest {
26+
class ProductServiceTest {
2627

2728
@Mock
2829
private ProductRepository queryProductRepository;
@@ -49,7 +50,7 @@ void setUp() {
4950

5051
@Test
5152
void save() {
52-
MultipartFile MULTIPART_FILE_PREPARED = new MockMultipartFile("test.jpg","test.jpg".getBytes(StandardCharsets.UTF_8));
53+
MultipartFile MULTIPART_FILE_PREPARED = new MockMultipartFile("test.jpg", "test.jpg".getBytes(StandardCharsets.UTF_8));
5354

5455
Product PRODUCT_BASE_PREPARED = Product.builder()
5556
.id(null)
@@ -72,7 +73,7 @@ void save() {
7273
.build();
7374

7475
Mockito.when(categoryRepository.save(PRODUCT_BASE_PREPARED.getCategory())).thenReturn(Category.builder().id(1L).name(PRODUCT_BASE_PREPARED.getCategory().getName()).build());
75-
Mockito.when(fileUpload.uploadFile("/images",MULTIPART_FILE_PREPARED)).thenReturn("test.jpg");
76+
Mockito.when(fileUpload.uploadFile("/images", MULTIPART_FILE_PREPARED)).thenReturn("test.jpg");
7677
Mockito.when(queryProductRepository.save(PRODUCT_BASE_PREPARED)).thenReturn(PRODUCT_SAVED_PREPARED);
7778

7879
Product product = productService.save(PRODUCT_BASE_PREPARED, MULTIPART_FILE_PREPARED);
@@ -88,7 +89,7 @@ void save() {
8889
}
8990

9091
@Test
91-
void findAll(){
92+
void findAll() {
9293
Product PRODUCT_SAVED_PREPARED = Product.builder()
9394
.id(1L)
9495
.name("Product 1")

src/test/java/com/example/store/user/application/UserServiceTest.kt

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -3,103 +3,63 @@ package com.example.store.user.application
33
import com.example.store.shared.domain.exception.ResourceNotFoundException
44
import com.example.store.user.domain.Role
55
import com.example.store.user.domain.User
6-
76
import com.example.store.user.domain.UserRepository
8-
97
import org.junit.jupiter.api.Assertions.assertEquals
10-
118
import org.junit.jupiter.api.Test
12-
139
import org.junit.jupiter.api.assertThrows
14-
1510
import org.junit.jupiter.api.extension.ExtendWith
16-
1711
import org.mockito.InjectMocks
18-
1912
import org.mockito.Mock
20-
2113
import org.mockito.Mockito
22-
2314
import org.mockito.junit.jupiter.MockitoExtension
24-
2515
import java.util.*
2616

2717
@ExtendWith(MockitoExtension::class)
28-
2918
class UserServiceTest {
3019

3120
@Mock
32-
3321
private lateinit var userRepository: UserRepository
34-
3522
@InjectMocks
36-
3723
private lateinit var userService: UserServiceImpl
3824

3925
@Test
40-
4126
fun findByIdWhenUserIdNoExistShouldReturnThrowResourceNotFoundException() {
42-
4327
val userId = UUID.randomUUID()
4428

4529
Mockito.`when`(userRepository.findById(Mockito.any(UUID::class.java))).thenReturn(Optional.empty())
46-
4730
val exception = assertThrows<ResourceNotFoundException> {
48-
4931
userService.findById(userId)
50-
5132
}
5233

53-
54-
5534
assertEquals("Usuario no encontrado", exception.message)
56-
5735
}
58-
5936
@Test
60-
6137
fun findByIdWhenUserIdExistShouldReturnUser() {
62-
6338
val userId = UUID.randomUUID()
6439

6540
Mockito.`when`(userRepository.findById(Mockito.any(UUID::class.java))).thenReturn(
6641
Optional.of(
67-
6842
User.builder()
69-
7043
.id(userId)
71-
7244
.email("JohnDoe@gmail.com")
73-
7445
.roles(setOf(Role.USER))
75-
7646
.password("password123")
77-
7847
.build()
79-
8048
)
8149
)
82-
8350
val user = userService.findById(userId)
8451

8552

8653

8754
assertEquals(userId, user.id)
88-
8955
}
90-
9156
@Test
92-
9357
fun findAllShouldReturnListOfUsers() {
94-
9558
Mockito.`when`(userRepository.findAll()).thenReturn(listOf())
96-
9759
val users = userService.findAll()
9860

9961

10062

10163
assertEquals(0, users.size)
102-
10364
}
104-
10565
}

0 commit comments

Comments
 (0)