Skip to content

feat: template Mega Man X#116

Open
leandrowork03 wants to merge 1 commit intoIgorHalfeld:masterfrom
leandrowork03:mega-man-x
Open

feat: template Mega Man X#116
leandrowork03 wants to merge 1 commit intoIgorHalfeld:masterfrom
leandrowork03:mega-man-x

Conversation

@leandrowork03
Copy link
Copy Markdown

Template Mega Man X no arquivo persons.js seguindo o padrão do projeto.

Notas:

  • Ajustei indentação conforme padrão ESLint.
  • Adicionei script "dev" no package.json para rodar localmente (não afeta funcionalidades).

Comment thread scripts/persons.js
image: 'https://i.imgur.com/s2vzuyb.png'
}
},
megamanx: {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tá indentado correto aqui? parece estranho

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pra mim parece errado tbm

Comment thread package.json
"husky": "^3.1.0",
"jest": "^24.9.0"
"jest": "^24.9.0",
"vite": "^7.0.6"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq instalou o vite?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não entendi a motivação tbm

@IgorHalfeld
Copy link
Copy Markdown
Owner

algum update @leandrowork03 ?

@leandrowork03
Copy link
Copy Markdown
Author

desculpe a demora em responder eu não havia visto, o projeto não estava rodando aqui, precisei fazer algumas adaptações para rodar aqui, mas sem comprometer nada do projeto

@rodrigoodev
Copy link
Copy Markdown
Collaborator

image

Copy link
Copy Markdown
Collaborator

@rodrigoodev rodrigoodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread scripts/persons.js
image: 'https://i.imgur.com/s2vzuyb.png'
}
},
megamanx: {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pra mim parece errado tbm

Comment thread package.json
"husky": "^3.1.0",
"jest": "^24.9.0"
"jest": "^24.9.0",
"vite": "^7.0.6"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não entendi a motivação tbm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants